Skip to content

Fix relative same host redirects in node middleware#88253

Merged
ijjk merged 1 commit into
canaryfrom
ijjk/fix-relative-redirect
Jan 8, 2026
Merged

Fix relative same host redirects in node middleware#88253
ijjk merged 1 commit into
canaryfrom
ijjk/fix-relative-redirect

Conversation

@ijjk

@ijjk ijjk commented Jan 8, 2026

Copy link
Copy Markdown
Member

This ensures we properly relativize URLs in node middleware when deployed and local. Tests weren't catching this previously as none were asserting the raw Location header value due to node-fetch auto-resolving the value.

Fixes: #87950
Closes: NEXT-4826

@nextjs-bot

nextjs-bot commented Jan 8, 2026

Copy link
Copy Markdown
Contributor

Tests Passed

@nextjs-bot

Copy link
Copy Markdown
Contributor

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ▁▁▃▁▁
Cold (First Request) 847ms 835ms ▇█▁▇█
Warm (Listen) 455ms 456ms ▁█▁▁█
Warm (First Request) 352ms 382ms ▁▁▁▁▂
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ▁▁▁▁▁
Cold (First Request) 1.799s 1.808s ▁▂▁▁▂
Warm (Listen) 455ms 456ms ▁▁▁▁▁
Warm (First Request) 1.860s 1.808s ▁▂▁▁▂

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.525s 4.495s ▁▂▆▃▄
Cached Build 4.464s 4.480s ▂▁▅▂▃
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 13.844s 13.834s ▁▁▁▁▃
Cached Build 13.875s 13.884s ▁▁▁▁▃
node_modules Size 457 MB 457 MB █████
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **431 kB** → **431 kB** ⚠️ +2 B

82 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 785 B 788 B
Total 785 B 788 B ⚠️ +3 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 451 B 451 B
Total 451 B 451 B

📦 Webpack

Client

Main Bundles
Canary PR Change
2086.HASH.js gzip 169 B N/A -
2161-HASH.js gzip 5.4 kB N/A -
2747-HASH.js gzip 4.48 kB N/A -
4322-HASH.js gzip 52.7 kB N/A -
ec793fe8-HASH.js gzip 62.3 kB N/A -
framework-HASH.js gzip 59.8 kB 59.8 kB
main-app-HASH.js gzip 248 B 254 B 🔴 +6 B (+2%)
main-HASH.js gzip 38.6 kB 38.9 kB
webpack-HASH.js gzip 1.68 kB 1.68 kB
1596.HASH.js gzip N/A 169 B -
2658-HASH.js gzip N/A 52.5 kB -
6349-HASH.js gzip N/A 4.46 kB -
7019-HASH.js gzip N/A 5.42 kB -
b17a3386-HASH.js gzip N/A 62.3 kB -
Total 225 kB 225 kB ⚠️ +163 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Total 39.4 kB 39.4 kB
Pages
Canary PR Change
_app-HASH.js gzip 194 B 193 B
_error-HASH.js gzip 182 B 182 B
css-HASH.js gzip 336 B 335 B
dynamic-HASH.js gzip 1.8 kB 1.8 kB
edge-ssr-HASH.js gzip 256 B 256 B
head-HASH.js gzip 352 B 349 B
hooks-HASH.js gzip 385 B 384 B
image-HASH.js gzip 580 B 580 B
index-HASH.js gzip 259 B 258 B
link-HASH.js gzip 2.5 kB 2.51 kB
routerDirect..HASH.js gzip 319 B 317 B
script-HASH.js gzip 385 B 387 B
withRouter-HASH.js gzip 316 B 315 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Total 7.97 kB 7.96 kB ✅ -8 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 124 kB 124 kB
page.js gzip 240 kB 241 kB
Total 364 kB 365 kB ⚠️ +1.06 kB
Middleware
Canary PR Change
middleware-b..fest.js gzip 653 B 654 B
middleware-r..fest.js gzip 155 B 156 B
middleware.js gzip 32.7 kB 32.9 kB
edge-runtime..pack.js gzip 842 B 842 B
Total 34.3 kB 34.6 kB ⚠️ +257 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 738 B 738 B
Total 738 B 738 B
Build Cache
Canary PR Change
0.pack gzip 3.63 MB 3.64 MB 🔴 +9.33 kB (+0%)
index.pack gzip 99.7 kB 98.5 kB 🟢 1.19 kB (-1%)
index.pack.old gzip 99.7 kB 99.7 kB
Total 3.83 MB 3.84 MB ⚠️ +8.1 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 303 kB 303 kB
app-page-exp..prod.js gzip 158 kB 158 kB
app-page-tur...dev.js gzip 303 kB 303 kB
app-page-tur..prod.js gzip 158 kB 158 kB
app-page-tur...dev.js gzip 299 kB 299 kB
app-page-tur..prod.js gzip 156 kB 156 kB
app-page.run...dev.js gzip 300 kB 300 kB
app-page.run..prod.js gzip 156 kB 156 kB
app-route-ex...dev.js gzip 68.7 kB 68.7 kB
app-route-ex..prod.js gzip 47.5 kB 47.5 kB
app-route-tu...dev.js gzip 68.7 kB 68.7 kB
app-route-tu..prod.js gzip 47.6 kB 47.6 kB
app-route-tu...dev.js gzip 68.3 kB 68.3 kB
app-route-tu..prod.js gzip 47.3 kB 47.3 kB
app-route.ru...dev.js gzip 68.3 kB 68.3 kB
app-route.ru..prod.js gzip 47.3 kB 47.3 kB
dist_client_...dev.js gzip 324 B 324 B
dist_client_...dev.js gzip 326 B 326 B
dist_client_...dev.js gzip 318 B 318 B
dist_client_...dev.js gzip 317 B 317 B
pages-api-tu...dev.js gzip 41.1 kB 41.1 kB
pages-api-tu..prod.js gzip 31.2 kB 31.2 kB
pages-api.ru...dev.js gzip 41 kB 41 kB
pages-api.ru..prod.js gzip 31.2 kB 31.2 kB
pages-turbo....dev.js gzip 50.8 kB 50.8 kB
pages-turbo...prod.js gzip 38.2 kB 38.2 kB
pages.runtim...dev.js gzip 50.7 kB 50.7 kB
pages.runtim..prod.js gzip 38.2 kB 38.2 kB
server.runti..prod.js gzip 62.2 kB 62.2 kB
Total 2.68 MB 2.68 MB ✅ -1 B

@ijjk ijjk enabled auto-merge (squash) January 8, 2026 02:19
@ijjk ijjk merged commit 0f9b732 into canary Jan 8, 2026
287 of 289 checks passed
@ijjk ijjk deleted the ijjk/fix-relative-redirect branch January 8, 2026 02:28
mischnic pushed a commit that referenced this pull request Jan 16, 2026
This ensures we properly relativize URLs in node middleware when
deployed and local. Tests weren't catching this previously as none were
asserting the raw Location header value due to node-fetch auto-resolving
the value.

Fixes: #87950
Closes: NEXT-4826
ztanner pushed a commit that referenced this pull request Jan 16, 2026
…#88630)

Backport #88253 into 16.1

Co-authored-by: JJ Kasper <jj@jjsweb.site>
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Next 16 (forced nodejs proxy runtime) broke relative URL redirects deployed on vercel (with matching deployment URLs)

3 participants