Fix logical NOT for string-backed boolean values - #1191
Draft
fallenmi wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1122.
Literal values passed to a SubTree remain strings in its blackboard. Script unary logical NOT rejected every string, including values that use the standard boolean spellings accepted by
convertFromString<bool>.Allow
!to interpret onlytrue/True/TRUE/1andfalse/False/FALSE/0. Other strings still raise the existingInvalid operator for std::stringerror, and the blackboard values remain unchanged for string consumers.Regression coverage includes:
_skipIf="!enabled"path;1/0values;Validation
cmake --build build --target behaviortree_cpp_test --parallel 8./build/tests/behaviortree_cpp_test --gtest_filter='SubTree.*:Preconditions.*:ParserTest.*:PortTest.*:PortTypeRules.*'— 110 passeduvx pre-commit run -agit diff --checkAI assistance disclosure
OpenAI Codex reproduced the issue, drafted the code and tests, checked the visible upstream overlap surface, and ran the validation listed above. The account owner remains responsible for the contribution.