Replace mb_str_split with str_split for key processing#105
Open
jbender0 wants to merge 1 commit into
Open
Conversation
DoubleArray::commonPrefixSearch() in Precompiled.php:147-170 is a byte-level double-array trie (ported from sentencepiece's C++ normalizer), but it iterates with mb_str_split() (character-wise) instead of byte-wise, then calls ord() on multi-byte characters - triggering a deprecation warning and, more importantly, silently truncating multi-byte UTF-8 input to its first byte, which breaks the trie lookup for any non-ASCII text (e.g. accented characters, non-Latin scripts) going through this normalizer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DoubleArray::commonPrefixSearch() in Precompiled.php:147-170 is a byte-level double-array trie (ported from sentencepiece's C++ normalizer), but it iterates with mb_str_split() (character-wise) instead of byte-wise, then calls ord() on multi-byte characters - triggering a deprecation warning and, more importantly, silently truncating multi-byte UTF-8 input to its first byte, which breaks the trie lookup for any non-ASCII text (e.g. accented characters, non-Latin scripts) going through this normalizer.
What:
Description:
Fixed a warning:
ord(): Providing a string that is not one byte long is deprecated. Use ord($str[0]) instead
And fixed silent dropping characters.