Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 68 additions & 0 deletions Sprint-2/implement_linked_list/linked_list.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
class Node:
__slots__ = ("value", "next", "previous")

def __init__(self, value):
self.value = value
self.next = None
self.previous = None
Comment on lines +1 to +7

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I suggest exploring the use of __slots__ to reduce memory usage?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I suggest exploring the use of __slots__ to reduce memory usage?

Thanks for the suggestion. I wasn't familiar with slots, so I looked into it and learned that it can reduce memory usage by avoiding an instance dictionary for each Node. I've updated the Node class to use slots.



class LinkedList:
def __init__(self):
self.head = None
self.tail = None

def push_head(self, value):
node = Node(value)

if self.head is None:
self.head = node
self.tail = node
else:
node.next = self.head
self.head.previous = node
self.head = node

return node

def pop_tail(self):
if self.tail is None:
return None

node = self.tail
value = node.value

self.remove(node)

return value

def remove(self, node):
if node.previous is not None:
node.previous.next = node.next
else:
self.head = node.next

if node.next is not None:
node.next.previous = node.previous
else:
self.tail = node.previous

node.next = None
node.previous = None

def move_to_head(self, node):
if node == self.head:
return

self.remove(node)

node.previous = None
node.next = self.head

if self.head is not None:
self.head.previous = node

self.head = node

if self.tail is None:
self.tail = node
Loading