Skip to content

London | 26-SDC-March | Jamal Laqdiem| Sprint 2 | Implement an LRU cache - #213

Open
jamallaqdiem wants to merge 1 commit into
CodeYourFuture:mainfrom
jamallaqdiem:fix-lru-cache-pr
Open

London | 26-SDC-March | Jamal Laqdiem| Sprint 2 | Implement an LRU cache#213
jamallaqdiem wants to merge 1 commit into
CodeYourFuture:mainfrom
jamallaqdiem:fix-lru-cache-pr

Conversation

@jamallaqdiem

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Implemented an LRU Cache with O(1) lookups and eviction logic.

@jamallaqdiem jamallaqdiem added Module-Complexity The name of the module. 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 13, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Well done.

Comment on lines +2 to +3
import os
sys.path.append(os.path.abspath(os.path.join(os.path.dirname(__file__), "../implement_linked_list")))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can include linked_lst.py from the other exercise in this folder, as this script requires it to work. If a reviewer haven't yet seen your LinkedList implementation, they may ask for it.

@jamallaqdiem jamallaqdiem Jul 15, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cjyuan thanks for the review, I tried that way in my PR Closed however the metadata for the PR check didn't allow it, so I had to close and open a new one.
which better way I should use?

@cjyuan cjyuan Jul 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The validation bot is very rigid -- it expects changes to be made only in some folder for each exercise.
So to by pass the check, you would have to copy the file linked_list.py into the implement_lru_cache folder. It's not a normal way to reuse code; just a way to by pass the bot check.

Don't worry about it.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Complexity The name of the module. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants