Glasgow | 26-SDC-Mar | Mohammed Abdoon | Sprint 1 | Analyse and Refactor Functions - #215
Open
M-Abdoon wants to merge 6 commits into
Open
Glasgow | 26-SDC-Mar | Mohammed Abdoon | Sprint 1 | Analyse and Refactor Functions#215M-Abdoon wants to merge 6 commits into
M-Abdoon wants to merge 6 commits into
Conversation
M-Abdoon
added
the
Needs Review
M-Abdoon
changed the title
M-Abdoon
added
📅 Sprint 1
M-Abdoon
changed the title
cjyuan
reviewed
Jul 17, 2026
Comment on lines
+22
to
+24
|
|
||
| // in this function, we need to use 2 loops to check if there is a pair of numbers that sum to the value. | ||
| // nothing can be optimized in this function, it is already efficient. No newline at end of file |
There was a problem hiding this comment.
-
What's the complexity of the original code?
-
With a different algorithm, the complexity of the function could be reduced.
| ...new Set(firstArray.filter((item) => secondArray.includes(item))), | ||
| ]; | ||
|
|
||
| // the function does not need to be optimized as it is already efficient. No newline at end of file |
There was a problem hiding this comment.
-
What's the complexity of the original code?
-
The complexity of the function could be reduced.
Comment on lines
+4
to
+6
| * Time Complexity: O(n) | ||
| * Space Complexity: O(n) | ||
| * Optimal Time Complexity: O(n) |
There was a problem hiding this comment.
Could you also indicate the time complexity of the original code?
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist