Skip to content

London| 26 March SDC | Jamal Laqdiem| Sprint 2 | Improve code with precomputing - #217

Open
jamallaqdiem wants to merge 1 commit into
CodeYourFuture:mainfrom
jamallaqdiem:improve-code-with-precomputing
Open

London| 26 March SDC | Jamal Laqdiem| Sprint 2 | Improve code with precomputing#217
jamallaqdiem wants to merge 1 commit into
CodeYourFuture:mainfrom
jamallaqdiem:improve-code-with-precomputing

Conversation

@jamallaqdiem

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

In these two exercises I optimised performance for the common_prefix and count_letters tasks by applying pre-computing strategies.

@jamallaqdiem jamallaqdiem added Module-Complexity The name of the module. 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 15, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is correct.

Can you use complexity to explain how the new implementation is better than the original implementation?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Complexity The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants