Skip to content

Barcelona | Oct-2025-1 | Ifeoma Osegbo | Sprint 1 | Complexity - #223

Closed
Ify-O wants to merge 5 commits into
CodeYourFuture:mainfrom
Ify-O:complexity-sprint1
Closed

Barcelona | Oct-2025-1 | Ifeoma Osegbo | Sprint 1 | Complexity#223
Ify-O wants to merge 5 commits into
CodeYourFuture:mainfrom
Ify-O:complexity-sprint1

Conversation

@Ify-O

@Ify-O Ify-O commented Jul 20, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Briefly explain your PR.

Summary

This PR refactors the JavaScript solutions for Sprint 1 by improving algorithm efficiency and documenting complexity analysis.

Changes

  • Refactored algorithms to reduce time complexity where possible
  • Added Big O time and space complexity comments
  • Documented optimal complexity for each solution
  • Kept all existing tests passing

Tasks Completed

  • calculateSumAndProduct
  • findCommonItems
  • hasPairWithSum
  • removeDuplicates

Questions

Ask any questions you have for your reviewer. You must remove this section if you have no questions.

@github-actions

Copy link
Copy Markdown

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@Ify-O Ify-O closed this Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant