Skip to content

NW | 2026-mar-sdc | Zabihollah Namazi | Sprint 1 | Hashtag slowing - #241

Open
ZabihollahNamazi wants to merge 2 commits into
CodeYourFuture:mainfrom
ZabihollahNamazi:hashtag-slowing-2
Open

NW | 2026-mar-sdc | Zabihollah Namazi | Sprint 1 | Hashtag slowing #241
ZabihollahNamazi wants to merge 2 commits into
CodeYourFuture:mainfrom
ZabihollahNamazi:hashtag-slowing-2

Conversation

@ZabihollahNamazi

@ZabihollahNamazi ZabihollahNamazi commented Jul 2, 2026

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

This PR replaces Old PR , which was closed due to a git branching issue. The previous branch accidentally included commits and tasks from an unrelated feature branch.
This new branch has been cleanly separated so it contains only the commits specific to this task.
I would really appreciate it if you could take a quick look and review this new PR . Thank you!

@ZabihollahNamazi ZabihollahNamazi added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Legacy-Code The name of the module. labels Jul 2, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You identified what could be done to stop the "loop" from happening, but have you tested your code to see if it has actually stopped the "fetch-render" loop?


Could you use AI to research:

On a legacy codebase, what's the guideline for formatting when fixing a bug? The existing code is formatted with formatter X, but I'm using formatter Y.
Should I reformat only the code I touch, leave the existing formatting as-is, or reformat the entire file?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Legacy-Code The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants