Skip to content

WestMidlands | 26-SDC-Mar | Chioma Okeke | Sprint 1 | profile login bug - #245

Open
JanefrancessC wants to merge 1 commit into
CodeYourFuture:mainfrom
JanefrancessC:login-bug
Open

WestMidlands | 26-SDC-Mar | Chioma Okeke | Sprint 1 | profile login bug#245
JanefrancessC wants to merge 1 commit into
CodeYourFuture:mainfrom
JanefrancessC:login-bug

Conversation

@JanefrancessC

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Fixed bug on profile.mjs file

@JanefrancessC JanefrancessC added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Legacy-Code The name of the module. labels Jul 2, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You fix the bug. Well done.

Could you use AI to research:

On a legacy codebase, what's the guideline for formatting when fixing a bug? The existing code is formatted with formatter X, but I'm using formatter Y.
Should I reformat only the code I touch, leave the existing formatting as-is, or reformat the entire file?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Legacy-Code The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants