Skip to content

WestMidlands | 26-SDC-Mar | Chioma Okeke | Sprint 1 | hashtag slows down browser #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JanefrancessC wants to merge 2 commits into
base: main
Choose a base branch
from
Open

WestMidlands | 26-SDC-Mar | Chioma Okeke | Sprint 1 | hashtag slows down browser #248

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f0210b
fix: guard hashtagView against slowing down browser
JanefrancessC Jul 2, 2026
1deac3f
fix: correct the guard
JanefrancessC Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions front-end/views/hashtag.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {renderOne, renderEach, destroy} from "../lib/render.mjs";
import { renderOne, renderEach, destroy } from "../lib/render.mjs";
import {
state,
apiService,
Expand All @@ -7,23 +7,25 @@ import {
getTimelineContainer,
getHeadingContainer,
} from "../index.mjs";
import {createLogin, handleLogin} from "../components/login.mjs";
import {createLogout, handleLogout} from "../components/logout.mjs";
import {createBloom} from "../components/bloom.mjs";
import {createHeading} from "../components/heading.mjs";
import { createLogin, handleLogin } from "../components/login.mjs";
import { createLogout, handleLogout } from "../components/logout.mjs";
import { createBloom } from "../components/bloom.mjs";
import { createHeading } from "../components/heading.mjs";

// Hashtag view: show all tweets containing this tag

function hashtagView(hashtag) {
destroy();

apiService.getBloomsByHashtag(hashtag);
if (hashtag !== state.currentHashtag) {
apiService.getBloomsByHashtag(hashtag);
}
Comment on lines +20 to +22

@cjyuan cjyuan Jul 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You identified what could be done to stop the "loop" from happening, but have you tested your code to see if it has actually stopped the "fetch-render" loop?


renderOne(
state.isLoggedIn,
getLogoutContainer(),
"logout-template",
createLogout
createLogout,
);
document
.querySelector("[data-action='logout']")
Expand All @@ -32,7 +34,7 @@ function hashtagView(hashtag) {
state.isLoggedIn,
getLoginContainer(),
"login-template",
createLogin
createLogin,
);
document
.querySelector("[data-action='login']")
Expand All @@ -42,14 +44,14 @@ function hashtagView(hashtag) {
state.currentHashtag,
getHeadingContainer(),
"heading-template",
createHeading
createHeading,
);
renderEach(
state.hashtagBlooms || [],
getTimelineContainer(),
"bloom-template",
createBloom
createBloom,
);
}

export {hashtagView};
export { hashtagView };