Use libddwaf builds - #109
Merged
Merged
Conversation
Closed
smola
force-pushed
the
smola/use-libddwaf-builds-3
branch
from
March 12, 2024 17:53
f4e4574 to
cac1db7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #109 +/- ##
=========================================
Coverage 58.55% 58.55%
Complexity 134 134
=========================================
Files 34 34
Lines 3458 3458
Branches 780 780
=========================================
Hits 2025 2025
Misses 900 900
Partials 533 533
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
manuel-alvarez-alvarez
approved these changes
Mar 13, 2024
smola
force-pushed
the
smola/use-libddwaf-builds-3
branch
from
March 14, 2024 07:49
279b5f3 to
b661e9d
Compare
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-use libddwaf builds, ensuring we use the same build as extensively tested upstream, with newer libc++, and shorter CI times.
Contributes to APPSEC-9858 by not depending on the Sqreen S3 bucket for libc++ builds.