Generate ESM alongside CJS#1082
Merged
Merged
Conversation
Since Vue 3 no longer has a default export, ESM doesn't like the import statement as is. Changing it to `import * as Vue from 'vue'` would work, but break tree-shaking in projects using this library. Since Vue 2 is long EOL (but still supported by this library) and `console.warn` works just as fine for Vue 2 (only with a little less context), removing that specialized support is fine in a minor version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows ESM-native apps to use this library without transpilation.
Note: Since Vue 3 no longer has a default export, ESM doesn't like the import statement
import Vue from 'vue'as is. Changing it toimport * as Vue from 'vue'would work, but break tree-shaking in projects using this library.Since Vue 2 is long EOL (but still supported by this library) and
console.warnworks just as fine for Vue 2 (only with a little less context), removing that specialized support is fine in a minor version.