Skip to content

Issue #241 - fix deferred authentication for Java21 EE10 runtime #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jul 3, 2024
Merged

Issue #241 - fix deferred authentication for Java21 EE10 runtime #243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...etty12/src/main/java/com/google/apphosting/runtime/jetty/EE10AppEngineAuthentication.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,10 +179,6 @@ public AuthenticationState validateRequest(Request req, Response res, Callback c
throw new ServerAuthException("validateRequest called with null response!!!");
}

if (AuthenticationState.Deferred.isDeferred(res)) {
return null;
}

try {
UserService userService = UserServiceFactory.getUserService();
// If the user is authenticated already, just create a
Expand All @@ -195,6 +191,10 @@ public AuthenticationState validateRequest(Request req, Response res, Callback c
}
}

if (AuthenticationState.Deferred.isDeferred(res)) {
return null;
}

try {
logger.atFine().log(
"Got %s but no one was logged in, redirecting.", request.getRequestURI());
Expand Down