Fix redirect loop bug in ResourceFileServlet - #333
Merged
Conversation
Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
|
Gemini encountered an error creating the summary. You can try again by commenting |
maigovannon
approved these changes
Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into a bug in
ResourceFileServlet, where trying to access a static file puts you in a redirect loop resulting in a URI looking like this:http://localhost:8080/hello.txt/index.html/index.html/index.html/index.html/index.html/index.html/index.html/index.html/index.html/index.html/index.html/index.html/index.html/index.html/index.html/index.html/index.html/index.html/index.html/The call to
getHolderEntry("/")was finding the context root mapping instead of the default mapping, this was causing an infinite redirect bug. This PR changes this to usegetServletMapping("/")which tests by pathSpec.