Replace dependency mysql:mysql-connector-java with com.mysql:mysql-connector-j 8.0.33 - #338
Conversation
ghost
left a comment
There was a problem hiding this comment.
Hi team,
I'm currently reviewing this pull request and will provide feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:
This pull request, submitted by Renovate Bot, aims to update the MySQL Connector/J dependency. The key change is replacing mysql:mysql-connector-java with com.mysql:mysql-connector-j version 8.0.33.
Here's a breakdown:
- Intent: Upgrade the MySQL database connector to the latest stable version.
- Changes:
- The
pom.xmlfile in theapplications/proberappdirectory has been modified. Specifically, lines 171 and 172 were changed to update the dependency's groupId and artifactId frommysql:mysql-connector-javatocom.mysql:mysql-connector-j, while keeping the version at 8.0.33.
- The
--- a/applications/proberapp/pom.xml
+++ b/applications/proberapp/pom.xml
@@ -168,8 +168,8 @@
<scope>compile</scope>
</dependency>
<dependency>
- <groupId>mysql</groupId>
- <artifactId>mysql-connector-java</artifactId>
+ <groupId>com.mysql</groupId>
+ <artifactId>mysql-connector-j</artifactId>
<version>8.0.33</version>
</dependency>
<dependency>- Activity: The pull request was automatically generated by Renovate, a dependency update bot. It's currently awaiting manual merge.
I'll provide a more detailed review shortly.
A little poem for your coding pleasure:
Dependencies change,
Renovate makes the update,
Code compiles clean.
ghost
left a comment
There was a problem hiding this comment.
This pull request replaces the mysql:mysql-connector-java dependency with com.mysql:mysql-connector-j. This change aligns with community recommendations and uses the minimal stable replacement version, which is a positive step towards better maintainability and compatibility. The version remains 8.0.33, ensuring consistency. However, it's crucial to thoroughly test this change to ensure no regressions are introduced, especially concerning database connectivity and interactions within the proberapp application. Consider adding a brief note to the release notes or README about this dependency update. I've also noticed the hardcoded database credentials in the pom.xml file, which is a security risk. While outside the scope of this PR, I strongly recommend addressing this by using environment variables or a more secure configuration management approach.
This PR contains the following updates:
8.0.33->8.0.33Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
This is a special PR that replaces
mysql:mysql-connector-javawith the community suggested minimal stable replacement version.Configuration
📅 Schedule: Branch creation - "* 0-3 * * 1" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.