Fix the conflicts when using afterEvaluate with other plugins - #2055
Merged
Conversation
This was referenced Jun 22, 2026
Goooler
changed the title
afterEvaluate with other plugins
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the afterEvaluate-time mutation of the shadowRuntimeElements configuration attributes in ShadowJavaPlugin, to avoid “configuration locked for mutation” conflicts when Shadow is used alongside other plugins (e.g., publishing / Artifactory), and records the fix in the Unreleased changelog.
Changes:
- Move target JVM attribute computation/setting into the
shadowRuntimeElementsconfiguration’sattributes {}block (instead ofafterEvaluate). - Keep the existing “opt-out” behavior for
addTargetJvmVersionAttributewhile avoiding late configuration mutation. - Add a “Fixed” entry to the Unreleased changelog describing the compatibility fix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowJavaPlugin.kt | Removes afterEvaluate attribute mutation and sets the target JVM attribute during configuration registration to prevent locking conflicts. |
| docs/changes/README.md | Adds an Unreleased “Fixed” changelog entry for the conflict/locking fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Goooler
force-pushed
the
g/20260622/remove-after-evaluated
branch
from
June 22, 2026 05:13
a61aedb to
cba7853
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2054.