Remove afterEvaluate when adding variants - #2056
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the afterEvaluate block previously used when conditionally adding the shadowRuntimeElements variant to the java software component, and records the change in the changelog.
Changes:
- Switch variant inclusion logic from
afterEvaluatetoConfigurationVariantDetails.skip()during variant configuration. - Keep the
shadowcomponent variant publishing behavior unchanged. - Add a changelog entry noting the removal of
afterEvaluatefor variant addition.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowJavaPlugin.kt | Removes afterEvaluate for adding the shadowRuntimeElements variant to the java component and replaces it with variant.skip() logic. |
| docs/changes/README.md | Adds an Unreleased changelog entry for the change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 task
Goooler
changed the title
afterEvaluate when adding variants
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up #1662 (comment).