Deprecate enableKotlinModuleRemapping for ShadowJar - #2073
Merged
Goooler merged 4 commits intoJul 5, 2026
Conversation
This was referenced Jun 29, 2026
Goooler
force-pushed
the
g/20260629/deprecate-enable-kotlin-module-remapping
branch
4 times, most recently
from
July 2, 2026 01:47
bdafc4c to
c06dd40
Compare
Goooler
force-pushed
the
g/20260629/deprecate-enable-kotlin-module-remapping
branch
from
July 5, 2026 13:23
c06dd40 to
b0b5cd7
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Clarify that file paths of Kotlin module metadata files are relocated unconditionally regardless of enableKotlinModuleRemapping, and that the option only controls whether contents remapping is applied.
Goooler
enabled auto-merge (squash)
July 5, 2026 14:02
DreierF
added a commit
to cqse/teamscale-java-profiler
that referenced
this pull request
Aug 17, 2026
Shadow deprecated `enableKotlinModuleRemapping` in 9.5.0 and removes it in Shadow 10 (GradleUp/shadow#2073). Applying the transformer explicitly keeps the contents of the `.kotlin_module` files relocated. The shaded agent jar is byte-identical to before. Also drop the four explicit relocate(...) calls. They are leftovers from the kotlin-shadow-relocator plugin removed in 3fd564f, where they took care of the Kotlin metadata that the transformer now handles. In regular builds they only duplicated what enableAutoRelocation already does, save for two unwanted string rewrites: the "retrofitBuilderAction" parameter name in HttpUtils and a string in retrofit's own @metadata, both caused by "retrofit" matching beyond package boundaries. In -Pdebug=true builds they relocated kotlin, okhttp3, okio and retrofit even though that build exists precisely to keep the package names in the jar matching the ones IntelliJ knows from the source. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2066.