Incorrect changes from 4.9 to 5.1

[dani-petrov]

Hello, i have recently updated from 4.9 to 5.1. I have a lot of tests which failed after the migration to the newest version. I have successfully migrated the Visitors according to the Migration Guide.

The first problem is with the dataType property:
4.9: According to me this is the correct representation, where The varchar length is stored in the argumentsStringList.

5.1: Incorrect representation where the length is part of the dataType

Another problem that i have discovered is with the UNSIGNED column specification:
4.9: Which I think is also the correct one: the unsigned column spec is inside the columnSpecs list

5.1: Incorrect, where unsigned is part of the dataType

These are the ones that I have discovered for now, probably there are more.
Were these changes intentional or were changed by mistake?

[manticore-projects]

Greetings,

to be very honest: I don't care much about DDL statements and just try to get them parsed somehow (especially when there are parser errors).
They have just too many RDBMS specific parts, far away from any standard to be useful in a RDBMS agnostic parser. And the Create/Alter Statement parts of the parser are grown over the time and not very well designed from begin.

So your helping hand will be very much welcome when you are interested in this particular topic.

[manticore-projects]

Btw, I believe that regarding the unsigned int, 5.1 is more correct than the previous one.