feat(loop): support eager_start in loop.create_task#748
Merged
Conversation
|
Tested this patch locally and it seems to work. |
fantix
approved these changes
May 1, 2026
Contributor
Author
|
@fantix Any luck we can move forward here? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds basic support for
eager_startkwarg inloop.create_task.Closes #746, #718
It also adjusts
loop.pyito mimic typeshed more closely as the type hints I was getting on my editor were not the ones I'd expect signature wise.Currently it relies on these two PR's from being merged
I tested this manually on Linux and OSX by building uvloop from the branch and running it on eager_start workloads on python 3.13 and 3.14.
Disclosure: This PR is made by human-only contribution without AI generated code.