Fix edge compute issues with cbor-x dynamic functions - #511
Merged
Conversation
MasterKale
approved these changes
Jan 26, 2024
Owner
There was a problem hiding this comment.
Welcome back @Maronato! Thank you again for helping the library track changes in Vercel. CI is happy so this seems fine for me to merge and release ![]()
Owner
|
@Maronato This fix is now live in @simplewebauthn/server@9.0.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While adding webauthn support to a Next.js app, I kept getting the following error during build:
Turns out
cbor-xdeclares some dynamic functions that are not compatible with Vercel's edge compute and Cloudflare workers (info).Thankfully, fixing it is fairly straighforward.
cbor-xexports a version of itself without these eval statements viacbor-x/index-no-evalI tested the change locally by changing the cbor import line in my node_modules to be
export * as cborx from 'cbor-x/index-no-eval';and it fixed the issue.
The Deno import can continue pointing to the regular export since it supports eval.
PS: a few months ago I merge a PR here for something related - lack of support for streaming APIs in serverless environments. That has since changed, so importing from
cbor-x/indexinstead ofcbor-x/encodeisn't an issue anymore.