Skip to content

feat(cli): support Containerfile and custom files in sandbox create #2453

Open
tirthpatel90 wants to merge 1 commit into
NVIDIA:mainfrom
tirthpatel90:fix/allow-containerfile-in-sandbox-create
Open

feat(cli): support Containerfile and custom files in sandbox create #2453
tirthpatel90 wants to merge 1 commit into
NVIDIA:mainfrom
tirthpatel90:fix/allow-containerfile-in-sandbox-create

Conversation

@tirthpatel90

Copy link
Copy Markdown

Fixes #2420

Summary

Updates the --from path resolution logic in openshell-cli to treat any existing valid file path as a container build file, removing rigid Dockerfile name restrictions.

Changes

  • Updated file resolution in resolve_from to accept any existing file passed to --from without requiring a Dockerfile name convention.
  • Updated directory resolution to fall back to Containerfile if Dockerfile is absent.
  • Updated filename_looks_like_dockerfile to include containerfile and .containerfile.
  • Updated error messages to include Containerfile.

…-from

Signed-off-by: Tirth Patel <tirthpatel5393@gmail.com>
@copy-pr-bot

copy-pr-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown

All contributors have signed the DCO ✍️ ✅
Posted by the DCO Assistant Lite bot.

@tirthpatel90

Copy link
Copy Markdown
Author

I have read the DCO document and I hereby sign the DCO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Containerfile named files for sandbox creation.

1 participant