fix(data): order GPU representation reads after writers - #182
Open
kevkrist wants to merge 3 commits into
Open
Conversation
kevkrist
marked this pull request as ready for review
August 13, 2026 14:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wait for recorded writer events before cloning, materializing, or converting GPU tables. Retain view ownership until asynchronous materialization completes, preventing cross-stream reads from racing producer work or freed buffers.
Regression coverage
This PR adds a deterministic cross-stream clone regression test in
test_data_representation.cpp. It initializes the source allocation to zeros, blocks the producer stream before a queued write and the recorded writer event, then calls clone() on a separate consumer stream.The test fails on main in two observable ways: clone() returns while the producer remains blocked, and the cloned buffer contains the stale zero pattern instead of the written value. The
mainimplementation schedules the deep copy on the consumer stream without first waiting for the source writer event. This PR inserts the necessary stream dependency, so clone() remains blocked until the writer completes and copies the expected bytes.The test commit also updates the remaining Catch2 v2 catch.hpp include to the Catch2 v3 catch_all.hpp header so the test target builds with the current dependency.
Validation