docs: full 5-repo oracle remeasure after the complete #218-#240 batch#243
Conversation
Remeasures all five pinned oracle targets (ShareX, MahApps.Metro, MaterialDesignInXamlToolkit, AvalonEdit, ClosedXML) on current main after the complete precision batch (#218-#229) and the #238 soundness regression + #240 hotfix, in one apples-to-apples pass. Baseline is self-regenerated rather than copied from prose: the extractor was also built at the Own.NET commit right after the original oracle-sweep-2026-07-10.md sweep landed (before any of #218-#225's fixes), run with the identical own-check.sh command against the same pinned target commits. This avoids stitching together three prior notes that each measured different repo subsets at different Own.NET commits. Headline: -51 findings, 0 added (no regressions), 0 UNEXPLAINED - every removed finding traced to a specific merged issue/PR by reading the actual current source at that location. ClosedXML delta is exactly zero against the pre-#225 baseline, independently confirming #240's own soundness-regression fix holds under a full own-check sweep (not just #240's own narrower --flow-locals spot-check). Previously confirmed true positives (ShareX ShapeManagerMenu/HistoryItemManager, AvalonEdit TextView, ClosedXML test cts/workbook) spot-checked present in current output. No analyzer code changed.
|
Warning Review limit reached
Next review available in: 16 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
… DAG, generated differential (#214) Closes the four blocking items from the checkpoint-2 review. The 66/66 covered parity result is unchanged. B1 — State satisfies the Lattice contract: - solver seeds each merge from the FIRST predecessor with an out-fact (clone) and joins the rest, matching Python in_state_of; join is thus only ever called between real predecessor states, never bottom.join(loaded). - State::join handles the bottom identity explicitly (bottom ∨ x = x even with active loans) and asserts FULL loan-map equality (owner+kind per binding), not just key equality. Python join tightened to full-map equality first (no-op: 132/132 green, fixture byte-identical) so the invariant matches. - tests: bottom-identity-with-loans, compatible-loan comm/assoc, same-key/ different-value fail-loud, real CFG borrow_mut spanning a branch merge. B2 — schedules are materially distinct: - true FIFO (VecDeque front/back) and true LIFO (Vec stack), not block-id-keyed aliases. Visit-order recorder proves >=3 distinct orders while all agree on the fixpoint; successor-order + block-ID permutation invariance; an ownership-specific (real State lattice) schedule-independence test. B3 — no production parser edge: - own-analysis reads the effect type via own_cfg::Effect (re-exported); own- syntax moved to dev-dependencies. DAG edge test filters to production (kind=null) deps; new assertion own_analysis_has_no_production_parser_edge. B4 — generated differential battery: - tests/test_diff_gen_fixtures.py deterministically generates 160 seeded ownership mini-programs (acquire/release/use/move/call/branch/loop/return) with Python (line,code) goldens; own-analysis/tests/diff_gen.rs replays with zero Python and prints seed+source on divergence. 160/160 exact match. Integration gate updated: final #214 merge gated on PR #243 (the separate OSS remeasure) being independently reviewed and merged. Checkpoint-3 scope clarified (lifetime/buffer/effect/DI as independent own-analysis impls; own-bridge wires facts but does not own algorithms; evidence/SARIF stay later steps). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AZjB2ggU9qm8vmuTQRtZXR
|
@coderabbitai review |
2 participants
Что и зачем
Phase 2 of a repository-state cleanup: a full, reproducible, apples-to-apples remeasure of current
mainacross all 5 pinned oracle targets (ShareX, MahApps.Metro, MaterialDesignInXamlToolkit, AvalonEdit, ClosedXML) after the complete precision batch (#218-#229) and the #238 soundness regression + #240 hotfix.Method: same pinned target commits as the established sweep (verified by
git rev-parseat checkout time — no upstream drift possible). Baseline is self-regenerated, not copied from prose: builtOwnSharp.Extractorat the Own.NET commit right after the originaloracle-sweep-2026-07-10.mdsweep landed (before any of #218-#225's fixes), ran the identicalscripts/own-check.sh --format sarif --severity warningcommand (sameOWN_EXTRA_REF_DIRSWindowsDesktop ref pack) against the same pinned targets. This gives one apples-to-apples diff across the entire batch instead of stitching together three prior notes that each covered different repo subsets at different Own.NET commits.Headline: −51 findings total, 0 added (no regressions), 0 UNEXPLAINED — every removed finding traced to a specific merged issue/PR by reading the actual current source at that location (not inferred from a shape's name). ClosedXML delta is exactly zero against the pre-#225 baseline — independently confirms #240's soundness fix holds under a full sweep, not just #240's own narrower spot-check. Previously confirmed true positives (ShareX
ShapeManagerMenu/HistoryItemManagercluster, AvalonEditTextView.csfields, ClosedXML testcts/workbook) spot-checked present in current output — nothing real disappeared.Full breakdown, stop-condition checklist, and per-target machine-readable JSON (schema: target/commit metadata, command, counts by rule, added/removed/changed with classification) are in
docs/notes/precision-remeasure-2026-07-12.mdanddocs/notes/precision-remeasure-2026-07-12-data/.Тип изменения
Как проверено
python tests/run_tests.py— 276/276, all suites greenruff check .— all checks passedmypy— no issues in 20 source filesOwnSharp.Extractorbuilt twice (baseline commit + currentmain, bothdotnet 8.0.422),own-check.shSARIF sweep run against each, diffed programmaticallyСвязанные issue
Refs #218, #219, #220, #222, #223, #224, #227, #228, #229, #238, #240 (measurement only — no issues closed by this PR).
Чеклист
docs:)No analyzer code changed in this PR.
Generated by Claude Code