docs: note on roslyn-tools (harness, not analysis) + the extractor CLI direction#25
Conversation
…I direction Records a scoping verdict so we don't re-open it: `dotnet/roslyn-tools` is infrastructure tooling around Roslyn (CLI/packaging/VSIX/signing/insertion), not a ready-made C# ownership frontend. The real C# sources are dotnet/roslyn + the Roslyn SDK/APIs, which OwnSharp.Extractor already uses. Captures what to borrow (CLI-first as a `dotnet tool`; repo-tooling layer separation; project-graph as a future category), what to avoid (don't depend on roslyn-tools; don't reimplement the checker in C# — P-001's seam stands), a concrete next PR (`.csproj -> facts.ownir.json` CLI + golden), and the WPF track priority order. Docs-only. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Rg8kSk1YT14x7A1vo5zgED
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds ChangesRoslyn-tools vs. extractor architecture note
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
A scoping note:
roslyn-toolsis harness, not analysisWhile the oracle run churns, recording a verdict so we don't re-open it later.
dotnet/roslyn-toolsis infrastructure tooling around Roslyn — its own README is terse ("A set of tools used by Roslyn"), builds in an Azure feed, full of insertion/release/signing/VSIX plumbing. It is not a ready-made C# ownership frontend. The real C# sources aredotnet/roslyn+ the Roslyn SDK/APIs, whichOwnSharp.Extractoralready uses.The new note (
docs/notes/roslyn-tools-and-cli.md) captures:C# extractor → OwnIR facts → Python Own.Core → diagnostics mapped back to C#; the C# side is a fact extractor, not a second checker (per P-001).dotnet tool(not VSIX first); repo-tooling layer separation (Own.Core / OwnSharp.Extractor / Own.Cli / Own.Tests / Own.Corpus); the project-graph as a future category for DI-lifetime work.roslyn-toolsas a dependency; don't reimplement the checker in C#..csproj → facts.ownir.jsonCLI + a golden, no scope creep.event += without -=→ DispatcherTimer → IDisposable fields →Subscribe()→IDisposable→ region/lifetime (OWN014).Docs-only; no code or workflow changes.
🤖 Generated with Claude Code
Generated by Claude Code
Summary by CodeRabbit