Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(mine_report): only absorb multi-line continuations while brackets are unbalanced The multi-line parser fix (85cdded) absorbed ANY non-matching line after a finding, so a stray line following a COMPLETE finding (e.g. build chatter leaking to stdout) was folded into its message instead of counted — breaking mine_report's selftest ("expected 1 unparsed, got 0"), the lint-job failure on the last two pushes. Track the running bracket balance of the finding's message: a real multi-line lambda body leaves it unbalanced, a complete finding is balanced. Absorb continuation lines only while unbalanced; once balanced, a further non-matching line is stray drift again. Both selftests green (mine_report 8/8, oracle_compare 19/19); the multi-line ScreenToGif findings still parse and a trailing stray line is still counted. #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
fix(mine_report): only absorb multi-line continuations while brackets are unbalanced The multi-line parser fix (85cdded) absorbed ANY non-matching line after a finding, so a stray line following a COMPLETE finding (e.g. build chatter leaking to stdout) was folded into its message instead of counted — breaking mine_report's selftest ("expected 1 unparsed, got 0"), the lint-job failure on the last two pushes. Track the running bracket balance of the finding's message: a real multi-line lambda body leaves it unbalanced, a complete finding is balanced. Absorb continuation lines only while unbalanced; once balanced, a further non-matching line is stray drift again. Both selftests green (mine_report 8/8, oracle_compare 19/19); the multi-line ScreenToGif findings still parse and a trailing stray line is still counted. #29
Changes from all commits
c8bafba226a2af51683b65ef565245a340d7a2e8792ea4d9370af820ab8f39ca722ecb7e6ca461beb01d85cdded1246b560d31e101f467a980dd30ed3d25c2afe8676File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.