-
Notifications
You must be signed in to change notification settings - Fork 0
fix(extractor): suppress OWN014 region-escape FP on the process-lived App singleton (mined from ScreenToGif) #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| using System; | ||
| using System.Windows; | ||
|
|
||
| namespace Own.Samples.WpfApp; | ||
|
|
||
| // P-004 process-lived-subscriber exemption (mined from ScreenToGif + its Translator). | ||
| // | ||
| // The WPF application object (`App`) is a process-lived singleton: subscribing it to | ||
| // a process-lived static event (AppDomain.CurrentDomain.UnhandledException) is the | ||
| // textbook global-exception hook and promotes nothing — App already lives for the | ||
| // whole process. So the static-source region escape (OWN014) must NOT fire on it. | ||
| // Two detection shapes, both must stay SILENT: | ||
|
|
||
| // (1) name-based: ScreenToGif's real shape — `partial class App` whose `: Application` | ||
| // lives in the generated `App.g.cs` partial the extractor never sees (here the | ||
| // only visible base is IDisposable). | ||
| public partial class App : IDisposable | ||
| { | ||
| private void App_Startup(object sender, EventArgs e) | ||
| { | ||
| AppDomain.CurrentDomain.UnhandledException += CurrentDomain_UnhandledException; | ||
| } | ||
|
|
||
| private void CurrentDomain_UnhandledException(object sender, UnhandledExceptionEventArgs e) | ||
| { | ||
| Console.WriteLine(e.ExceptionObject); | ||
| } | ||
|
|
||
| public void Dispose() { } | ||
| } | ||
|
|
||
| // (2) base-based: a custom-named application object deriving from `Application` | ||
| // directly in the .cs (the base stays unresolved on the Linux runner, but the | ||
| // syntactic base-name detection still applies). | ||
| public class BootstrapApp : Application | ||
| { | ||
| public void Init() | ||
| { | ||
| AppDomain.CurrentDomain.UnhandledException += OnUnhandled; | ||
| } | ||
|
|
||
| private void OnUnhandled(object sender, UnhandledExceptionEventArgs e) | ||
| { | ||
| Console.WriteLine(e.ExceptionObject); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.