Skip to content

Read test_pwt.csv from data-lectures (Track D) - #612

Merged
mmcky merged 1 commit into
mainfrom
repoint-track-d
Aug 18, 2026
Merged

Read test_pwt.csv from data-lectures (Track D)#612
mmcky merged 1 commit into
mainfrom
repoint-track-d

Conversation

@mmcky

@mmcky mmcky commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Repoints all four test_pwt.csv reads to the copy landed in QuantEcon/data-lectures#98, using the CPython URL form github.com/QuantEcon/data-lectures/raw/main/lectures/test_pwt.csv per that repo's AGENTS.md.

One unsplit literal in pandas.md; the three reads in polars.md each built the URL by concatenation across three source lines and are collapsed to single literals rather than patched (the NEWQDATA precedent — editing the stem line alone leaves the filename appended to a dead path, and a whole-URL grep returns a confident zero against the wrapped form). pandas.md's prose drops the stale pandas/data/ path prefix; the PWT link is unchanged.

Merging this PR auto-triggers the three sync-translations workflows (they fire on merged PRs touching lectures/**/*.md), which is how the repoint reaches lecture-python-programming.zh-cn/.fr/.fa — their pandas and polars lectures fetch the same raw URL live at cell execution. The local copy is deliberately not deleted here: deletion follows in a separate PR only after the translations have synced and all four sites republished, because a premature deletion breaks those notebooks at runtime with no stale-serving grace period.

Sweep evidence: after the edit, zero remaining references to this dataset outside the new form — four data-lectures/raw/main reads present (positive control), three test_pwt mentions per file (read plus prose).

🤖 Generated with Claude Code

One out-of-scope finding from the sweep, recorded for completeness: python_advanced_features.md:1173 links this repo's own raw URL for test_table.csv in exercise prose — a different file, a prose navigation link rather than a code read, in the class QuantEcon/data-lectures#42 already tracks. Untouched here.

All four reads pointed at this repo's own raw URL — one unsplit literal
in pandas.md and three URLs split across three string literals each in
polars.md. Each collapses to a single literal of the data-lectures form
(github.com/QuantEcon/data-lectures/raw/main/lectures/test_pwt.csv);
patching the stem line alone would have left the filename appended to a
path that no longer exists in the flat published tree. pandas.md's
prose loses the stale pandas/data/ path prefix.

Data landed first in QuantEcon/data-lectures#98. The local copy at
_static/lecture_specific/pandas/data/ is deleted in a follow-up PR
only after this repoint has propagated to the three synced translation
repos (.zh-cn/.fr/.fa) and all four sites have republished — their
lectures fetch the same URL live at cell execution.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 18, 2026 01:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Repoints the Penn World Tables sample dataset (test_pwt.csv) used in the lecture notebooks to the canonical copy in QuantEcon/data-lectures, ensuring the pandas and polars lectures fetch the same shared source at execution time.

Changes:

  • Updated the pandas lecture to read test_pwt.csv from https://github.com/QuantEcon/data-lectures/raw/main/lectures/test_pwt.csv and adjusted prose to remove the stale local path reference.
  • Updated the polars lecture to use the same new URL for all three dataset reload/read sites, collapsing the previous multi-line concatenated URL into a single literal.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
lectures/pandas.md Updates the example CSV read URL and aligns prose with the new dataset location.
lectures/polars.md Updates all test_pwt.csv reads to the new shared data-lectures raw URL.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

Copy link
Copy Markdown

@mmcky
mmcky merged commit 55c87c9 into main Aug 18, 2026
5 checks passed
@mmcky
mmcky deleted the repoint-track-d branch August 18, 2026 01:13
@mmcky

mmcky commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

✅ Translation sync completed (zh-cn)

Target repo: QuantEcon/lecture-python-programming.zh-cn
Translation PR: QuantEcon/lecture-python-programming.zh-cn#92
Files synced (2):

  • lectures/pandas.md
  • lectures/polars.md

@mmcky

mmcky commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

✅ Translation sync completed (fr)

Target repo: QuantEcon/lecture-python-programming.fr
Translation PR: QuantEcon/lecture-python-programming.fr#33
Files synced (2):

  • lectures/pandas.md
  • lectures/polars.md

@mmcky

mmcky commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

✅ Translation sync completed (fa)

Target repo: QuantEcon/lecture-python-programming.fa
Translation PR: QuantEcon/lecture-python-programming.fa#153
Files synced (2):

  • lectures/pandas.md
  • lectures/polars.md

mmcky added a commit to QuantEcon/data-lectures that referenced this pull request Aug 18, 2026
Both repoint PRs merged 2026-08-18: the three advanced.myst reads in
QuantEcon/lecture-python-advanced.myst#375 and the four programming
reads in QuantEcon/lecture-python-programming#612. Statuses flip to
repointed, repoints entries filled, the landed-state consumer notes
come off the two direct repos, and the dataBHS.mat annotation is
deleted now that nothing reads the .mat (its successor manifest is
dataBHS.csv.yml).

The six translation-repo consumer notes on test_pwt.csv.yml stay:
those repos read lecture-python-programming's raw URL until their
sync-translations runs (fired by the #612 merge, in progress at this
commit) land and their sites republish — which is what gates the
source-copy deletion.

Measured in both directions against post-merge consumer mains:
repointed gives exit 0 with all five problem buckets empty; main's
landed state gives exit 1 with four migration_inconsistencies, one per
file. Verified the manifest edits touched nothing else: for each of
the four manifests, the only top-level key differing from main is
consumers (parsed comparison, not a patch eyeball).

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
@mmcky

mmcky commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

\translate-resync

Regenerating the French sync for this repoint from current fr main — the original fr#33 conflicted with fr#29 after its last rebase and was superseded. zh-cn and fa already merged their syncs of this PR, so their runs should produce no new content.

@mmcky

mmcky commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

✅ Translation sync completed (zh-cn)

Target repo: QuantEcon/lecture-python-programming.zh-cn
Translation PR: QuantEcon/lecture-python-programming.zh-cn#94
Files synced (2):

  • lectures/pandas.md
  • lectures/polars.md

@mmcky

mmcky commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

✅ Translation sync completed (fr)

Target repo: QuantEcon/lecture-python-programming.fr
Translation PR: QuantEcon/lecture-python-programming.fr#35
Files synced (2):

  • lectures/pandas.md
  • lectures/polars.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants