Conversation
Signed-off-by: lelia <2418071+lelia@users.noreply.github.com>
Signed-off-by: lelia <2418071+lelia@users.noreply.github.com>
Signed-off-by: lelia <2418071+lelia@users.noreply.github.com>
Signed-off-by: lelia <2418071+lelia@users.noreply.github.com>
Contributor
Author
|
bugbot run |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.
Autofix Details
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Dispatch republish wrong checkout ref
- Exported the resolved tag ref as a resolve-version output and plumbed it through a new ref input to the reusable pipeline's checkout so build-test-push builds from the specified tag instead of the default branch HEAD.
Or push these changes by commenting:
@cursor push 4d512fb46b
Preview (4d512fb46b)
diff --git a/.github/workflows/_docker-pipeline.yml b/.github/workflows/_docker-pipeline.yml
--- a/.github/workflows/_docker-pipeline.yml
+++ b/.github/workflows/_docker-pipeline.yml
@@ -56,6 +56,11 @@ on:
type: string
required: false
default: "dev"
+ ref:
+ description: "Git ref to check out (e.g. refs/tags/v2.0.3). Empty checks out the caller's default ref — used by the publish workflow to build from the resolved release tag on workflow_dispatch."
+ type: string
+ required: false
+ default: ""
secrets:
DOCKERHUB_USERNAME:
required: false
@@ -56,6 +56,11 @@ on:
type: string
required: false
default: "dev"
+ ref:
+ description: "Git ref to check out (e.g. refs/tags/v2.0.3). Empty checks out the caller's default ref — used by the publish workflow to build from the resolved release tag on workflow_dispatch."
+ type: string
+ required: false
+ default: ""
secrets:
DOCKERHUB_USERNAME:
required: false
@@ -71,6 +76,7 @@ jobs:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
+ ref: ${{ inputs.ref }}
persist-credentials: false
- name: 🔨 Set up Docker Buildx
@@ -71,6 +76,7 @@ jobs:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
+ ref: ${{ inputs.ref }}
persist-credentials: false
- name: 🔨 Set up Docker Buildx
diff --git a/.github/workflows/publish-docker.yml b/.github/workflows/publish-docker.yml
--- a/.github/workflows/publish-docker.yml
+++ b/.github/workflows/publish-docker.yml
@@ -43,6 +43,7 @@ jobs:
runs-on: ubuntu-latest
outputs:
version: ${{ steps.version.outputs.clean }}
+ ref: ${{ steps.version.outputs.ref }}
steps:
- name: 🏷️ Resolve version
id: version
@@ -43,6 +43,7 @@ jobs:
runs-on: ubuntu-latest
outputs:
version: ${{ steps.version.outputs.clean }}
+ ref: ${{ steps.version.outputs.ref }}
steps:
- name: 🏷️ Resolve version
id: version
@@ -130,6 +131,7 @@ jobs:
arch_label: ${{ matrix.arch }}
push: true
version: ${{ needs.resolve-version.outputs.version }}
+ ref: ${{ needs.resolve-version.outputs.ref }}
secrets:
DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
@@ -130,6 +131,7 @@ jobs:
arch_label: ${{ matrix.arch }}
push: true
version: ${{ needs.resolve-version.outputs.version }}
+ ref: ${{ needs.resolve-version.outputs.ref }}
secrets:
DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}You can send follow-ups to the cloud agent here.
Signed-off-by: lelia <2418071+lelia@users.noreply.github.com>
Signed-off-by: lelia <2418071+lelia@users.noreply.github.com>
Contributor
Author
|
bugbot run |
Signed-off-by: lelia <2418071+lelia@users.noreply.github.com>
Contributor
Author
|
bugbot run |
All image variants now publish to the single socket-basics repository per registry, distinguished by tag suffix (2.1.0 vs 2.1.0-heavy) instead of a separate socket-basics-heavy repository. This follows the standard Docker variant convention (like :slim/:alpine), requires no new Docker Hub repo, token rescoping, or GHCR package visibility changes, and makes retiring the POC variant trivial. - _docker-pipeline.yml: new push_name input decouples the registry repo from the local build/artifact name - publish-docker.yml: merge-manifests iterates variants with a tag_suffix, tags via metadata-action flavor suffix, and inspects both suffixed tags Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
1 issue from previous review remains unresolved.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit fbf94ea. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
socket-basicsrepository on each registry, distinguished by tag suffix (2.1.0vs2.1.0-heavy) — no separate-heavyrepo, so existing registry credentials and GHCR package visibility carry over unchanged.This follows the direction from #69: prefer native per-arch Docker publishing and keep the image release path simple to maintain.
Closes #69
Note
Medium Risk
Touches the production Docker publish path (multi-arch manifests and new variant tags); mitigated by expanded CI matrices, digest validation, and post-publish platform inspection.
Overview
Docker release now builds main and heavy images on native
linux/amd64andlinux/arm64runners, runs smoke/integration per matrix cell, pushes per-arch by digest to GHCR and Docker Hub, thenmerge-manifestsassembles2.x.yand2.x.y-heavytags on the singlesocket-basicsrepo (no separate heavy repository).The reusable
_docker-pipelineworkflow gainsruns_on,arch_label,push_name, checkoutref, and digest artifacts; tagging moves from per-buildmetadata-actiontodocker buildx imagetools create.resolve-versionvalidates semver and resolves manual dispatch tags before checkout.Dockerfile.heavyplusdocker-heavy-entrypoint.shinstall pinnedsocketsecurityand dispatchsocket-basics/socketcli; smoke CI adds aheavycheck set andLICENSE.mdis included in image builds.Reviewed by Cursor Bugbot for commit fbf94ea. Configure here.