Skip to content

add and fill 3 dots menu - #729

Open
bourgeoa wants to merge 2 commits into
stagingfrom
3-dots
Open

add and fill 3 dots menu#729
bourgeoa wants to merge 2 commits into
stagingfrom
3-dots

Conversation

@bourgeoa

@bourgeoa bourgeoa commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Add 3 dots menu and fill with all panes except the first one (human rendering) and sharing-pane.

There is a bug in solid-ui

It's a bug in solid-ui-menu: syncItems filters children without slot, then assigns them slot — so the second time it runs, all children have a slot and get filtered out. Let me work around it by using directly:

…@3.1.3-13 pane-registry@3.1.2-2 activitystreams-pane@1.0.3-4 chat-pane@3.0.4-3 contacts-pane@3.2.1-5 folder-pane@3.1.1-2 issue-pane@3.0.3-1 meeting-pane@3.0.3-1 profile-pane@3.2.3-4 source-pane@3.1.1-5) (latest: rdflib@2.4.0)

@SharonStrats SharonStrats left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bourgeoa I'm so sorry I don't think I'll be able to use it. I had already did it in a very different way. If I bring it into my branch it will cause me problems I think. I'll have a closer look later and see if I can do anything about this to use part of your work at least.

to give you some context. In source pane I had built the header and I have moved that into solid-panes. the summary (info about file like name) is in one web component and the controls are in another and then there is a header wrapper web component.

I had the same issue as you about the solid-ui-menu. I ended up solving it by changing the pane rerender to only remove the "pane" section not the header. When it was removing the table the menu items got lost and then weren't recreated. That seems to be working now.

@bourgeoa

bourgeoa commented Aug 2, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @SharonStrats
I did not find your PR branch work on GitHub.com that's why I did it.

We need an implementation logic for 3-dots menu to stop our weeks discussion about which panes are in and out and no way to see it structurally implemented and pushed to sharing

The panes order is significant.

@bourgeoa

bourgeoa commented Aug 2, 2026

Copy link
Copy Markdown
Contributor Author

solid-ui-menu issue bug SolidOS/solid-ui#849

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants