docs: keep platform specifics out of the generic core - #314
Open
morgan-wowk wants to merge 1 commit into
Open
Conversation
This was referenced Aug 6, 2026
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
morgan-wowk
changed the title
morgan-wowk
marked this pull request as ready for review
August 6, 2026 22:49
Add a repo-root CLAUDE.md with the rule the orchestrator and launcher interface are built on: the generic core stays platform-agnostic; platform-specific classification lives in the concrete launcher and reaches the orchestrator as a typed LauncherError. Co-authored-by: Morgan Wowk <morgan.wowk@shopify.com>
morgan-wowk
force-pushed
the
vanished-pods-and-failed-launches
branch
from
August 6, 2026 23:21
eaf6fec to
90206b6
Compare
morgan-wowk
force-pushed
the
docs-agent-platform-agnostic-rule
branch
from
August 6, 2026 23:21
cda1bdd to
2e36f80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a repo-root
CLAUDE.mddocumenting the architectural rule this stack is built around: the generic core stays platform-agnostic.orchestrator_sql.py) and the launcher interface (launchers/interfaces.py) must not inspect HTTP status codes, Kubernetes exceptions, or any other backend detail.kubernetes_launchers.py), which translates backend failures into typed, platform-neutralLauncherErrors.isinstance(...),err.is_retriable).Why
The rest of this stack (#312, #313) moved HTTP/Kubernetes classification out of the orchestrator and into the launcher. This file captures that boundary so future changes — by humans or coding agents — don't reintroduce platform specifics into the generic core.
Impact
Docs only. No code or runtime behaviour changes.