Skip to content

resolve permissions: drives#380

Open
jashkahar wants to merge 1 commit into
actions:mainfrom
jashkahar:jashkahar/drives-permission-yaml-schema
Open

resolve permissions: drives#380
jashkahar wants to merge 1 commit into
actions:mainfrom
jashkahar:jashkahar/drives-permission-yaml-schema

Conversation

@jashkahar

Copy link
Copy Markdown

This adds the drives workflow permission to the schema so it validates cleanly, while keeping it hidden from autocomplete until GA.

Gated behind the allowDrivesPermissionAutocomplete ff.

@jashkahar jashkahar requested a review from a team as a code owner July 8, 2026 19:07
Copilot AI review requested due to automatic review settings July 8, 2026 19:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for the drives workflow permission in the workflow schema so workflows validate successfully, while gating its appearance in autocomplete behind a feature flag until GA.

Changes:

  • Add permissions.drives to workflow-v1.0.json with the appropriate permission-level type and description.
  • Gate drives permission key completion behind allowDrivesPermissionAutocomplete in the language service.
  • Introduce the allowDrivesPermissionAutocomplete experimental feature flag and add completion tests for enabled/disabled/default behavior (including job-level permissions).
Show a summary per file
File Description
workflow-parser/src/workflow-v1.0.json Adds drives to the permissions mapping so schema validation accepts it.
languageservice/src/complete.ts Filters drives from permissions-key completions unless the feature flag is enabled.
languageservice/src/complete.test.ts Adds coverage for drives completion behavior at workflow and job scopes under the feature flag.
expressions/src/features.ts Defines the new experimental feature flag and registers it in allFeatureKeys.
expressions/src/features.test.ts Ensures the new feature flag key is included in the known feature key list.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 5/5 changed files
  • Comments generated: 0
  • Review effort level: Low

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants