resolve permissions: drives#380
Open
jashkahar wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for the drives workflow permission in the workflow schema so workflows validate successfully, while gating its appearance in autocomplete behind a feature flag until GA.
Changes:
- Add
permissions.drivestoworkflow-v1.0.jsonwith the appropriate permission-level type and description. - Gate
drivespermission key completion behindallowDrivesPermissionAutocompletein the language service. - Introduce the
allowDrivesPermissionAutocompleteexperimental feature flag and add completion tests for enabled/disabled/default behavior (including job-level permissions).
Show a summary per file
| File | Description |
|---|---|
| workflow-parser/src/workflow-v1.0.json | Adds drives to the permissions mapping so schema validation accepts it. |
| languageservice/src/complete.ts | Filters drives from permissions-key completions unless the feature flag is enabled. |
| languageservice/src/complete.test.ts | Adds coverage for drives completion behavior at workflow and job scopes under the feature flag. |
| expressions/src/features.ts | Defines the new experimental feature flag and registers it in allFeatureKeys. |
| expressions/src/features.test.ts | Ensures the new feature flag key is included in the known feature key list. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Low
ericsciple
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the drives workflow permission to the schema so it validates cleanly, while keeping it hidden from autocomplete until GA.
Gated behind the
allowDrivesPermissionAutocompleteff.