Skip to content

Fix typos discovered by codespell#1068

Closed
cclauss wants to merge 1 commit into
actions:mainfrom
cclauss:codespell
Closed

Fix typos discovered by codespell#1068
cclauss wants to merge 1 commit into
actions:mainfrom
cclauss:codespell

Conversation

@cclauss

@cclauss cclauss commented Mar 30, 2025

Copy link
Copy Markdown
Contributor

Description:
Describe your changes.

https://pypi.org/project/codespell

codespell --skip="./dist/cache-save/*" --write-changes \
    --ignore-words-list=aas,abd,addin,afterall,caf,calender,compre,coreutil,fo,fpr,iif,nam,nervana,ontext,ser,sycle,trys,vor

Please do an extra review on the proposed code change on lines 19176 and 19180.
These proposed changes might fix a bug where the correct spelling on line 19178 differs from these two typos.

-     var callback = function (error, responce) {
+     var callback = function (error, response) {
        request.removeListener('error', callback);
        request.removeListener('response', onResponse);

-       return cb.call(this, error, responce);
+       return cb.call(this, error, response);
      };

Related issue:
Add link to the related issue.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@cclauss
cclauss requested a review from a team as a code owner March 30, 2025 06:45
@priya-kinthali

Copy link
Copy Markdown
Contributor

Hello @cclauss👋, The fixes are accurate, but they're all in dist/setup/index.js, which is an auto-generated bundle, edits here get overwritten on the next build, and most of these typos come from third-party dependencies rather than our own code. Closing this PR for now. Thanks again for contributing!

@cclauss
cclauss deleted the codespell branch July 21, 2026 08:29
@cclauss

cclauss commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Where can I find the upstream code that dist/setup/index.js is generated from? Is it open source?

@priya-kinthali

Copy link
Copy Markdown
Contributor

Hello @cclauss,
dist/setup/index.js is auto-generated from this repo's TypeScript sources in src/ using @vercel/ncc (via npm run build).
That said, most of the typos in this diff seem to come from third-party dependencies(for example in @azure/storage-blob) that get bundled into the file. The best place to fix them is upstream in each package's own repo, those fixes will then flow back to us when we update the dependency. Hope this clarifies!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants