You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please do an extra review on the proposed code change on lines 19176 and 19180.
These proposed changes might fix a bug where the correct spelling on line 19178 differs from these two typos.
- var callback = function (error, responce) {+ var callback = function (error, response) {
request.removeListener('error', callback);
request.removeListener('response', onResponse);
- return cb.call(this, error, responce);+ return cb.call(this, error, response);
};
Related issue:
Add link to the related issue.
Check list:
Mark if documentation changes are required.
Mark if tests were added or updated to cover the changes.
Hello @cclauss👋, The fixes are accurate, but they're all in dist/setup/index.js, which is an auto-generated bundle, edits here get overwritten on the next build, and most of these typos come from third-party dependencies rather than our own code. Closing this PR for now. Thanks again for contributing!
Hello @cclauss, dist/setup/index.js is auto-generated from this repo's TypeScript sources in src/ using @vercel/ncc (via npm run build).
That said, most of the typos in this diff seem to come from third-party dependencies(for example in @azure/storage-blob) that get bundled into the file. The best place to fix them is upstream in each package's own repo, those fixes will then flow back to us when we update the dependency. Hope this clarifies!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Describe your changes.
https://pypi.org/project/codespell
Please do an extra review on the proposed code change on lines 19176 and 19180.
These proposed changes might fix a bug where the correct spelling on line 19178 differs from these two typos.
Related issue:
Add link to the related issue.
Check list: