Skip to content

Added anti-pattern example for Props Naming rule, changed className props in examples#1620

Merged
ljharb merged 2 commits into
airbnb:masterfrom
lasota-piotr:classname-props
Oct 25, 2017
Merged

Added anti-pattern example for Props Naming rule, changed className props in examples#1620
ljharb merged 2 commits into
airbnb:masterfrom
lasota-piotr:classname-props

Conversation

@lasota-piotr

@lasota-piotr lasota-piotr commented Oct 25, 2017

Copy link
Copy Markdown
Contributor
  • Added anti-pattern example for Props Naming rule with using className
  • To be consistent with Props Naming rule changed className to variant props in others examples

ljharb
ljharb approved these changes Oct 25, 2017
View reviewed changes

@ljharb ljharb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me

@ljharb
ljharb merged commit 9edcdde into airbnb:master Oct 25, 2017
rafiquecudjoe pushed a commit to rafiquecudjoe/javascript that referenced this pull request Jun 7, 2026
@ljharb
Merge pull request airbnb#1620 from lasota-piotr/classname-props
572ea45 
[guide] [react] Added anti-pattern example for Props Naming rule, changed className props in examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb approved these changes

Assignees

No one assigned

Labels

editorial react

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lasota-piotr @ljharb