Resolvers can return redirect command - #54556
Closed
atscott wants to merge 1 commit into
Closed
Conversation
atscott
added
state: blocked
area: core
angular-robot
Bot
added
detected: breaking change
Returning a `RedirectCommand` from a resolver can be interpreted as distinctly different from regular resolved data. When a resolver returns `RedirectCommand` we can interperet this as an intention to redirect in the same way as other guards. resolves angular#29089
atscott
force-pushed
the
resolversCanReturnRedirectCommand
branch
from
March 21, 2024 15:44
9da6905 to
935e13e
Compare
angular-robot
Bot
removed
the
detected: breaking change
atscott
marked this pull request as ready for review
March 21, 2024 15:45
pullapprove
Bot
requested review from
dylhunn,
jessicajaniuk and
pkozlowski-opensource
March 21, 2024 15:45
jessicajaniuk
approved these changes
Mar 25, 2024
jessicajaniuk
left a comment
jessicajaniuk
left a comment
Contributor
There was a problem hiding this comment.
reviewed-for: public-api
Contributor
Author
pkozlowski-opensource
approved these changes
Mar 29, 2024
pkozlowski-opensource
left a comment
pkozlowski-opensource
left a comment
Member
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
Contributor
Author
|
This PR was merged into the repository by commit 87f3f27. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returning a
RedirectCommandfrom a resolver can be interpreted asdistinctly different from regular resolved data. When a resolver returns
RedirectCommandwe can interperet this as an intention to redirect inthe same way as other guards.
resolves #29089