Platform-server: remove several deprecated APIs - #54874
Closed
alan-agius4 wants to merge 5 commits into
Closed
Conversation
alan-agius4
added
the
target: major
angular-robot
Bot
added
the
detected: breaking change
…le` API BREAKING CHANGE: deprecated `ServerTransferStateModule` has been removed. `TransferState` can be use without providing this module.
BREAKING CHANGE: deprecated `platformDynamicServer` has been removed. Add an `import @angular/compiler` and replace the usage with `platformServer`
…seUrl` from `PlatformConfig` BREAKING CHANGE: deprecated `useAbsoluteUrl` and `baseUrl` been removed from `PlatformConfig`. Provide and absolute `url` instead.
alan-agius4
force-pushed
the
remove-apis-deprecated
branch
from
March 15, 2024 10:34
c678b4c to
4166a58
Compare
alan-agius4
changed the title
alan-agius4
added
the
refactoring
BREAKING CHANGE: Legacy handling or Node.js URL parsing has been removed from `ServerPlatformLocation`. The main differences are; - `pathname` is always suffixed with a `/`. - `port` is empty when `http:` protocol and port in url is `80` - `port` is empty when `https:` protocol and port in url is `443`
This is following a number of cleanups.
alan-agius4
force-pushed
the
remove-apis-deprecated
branch
from
March 15, 2024 10:46
4166a58 to
97cba0b
Compare
alan-agius4
marked this pull request as ready for review
March 15, 2024 10:47
alan-agius4
added
the
action: review
AndrewKushnir
changed the title
AndrewKushnir
approved these changes
Mar 15, 2024
AndrewKushnir
left a comment
AndrewKushnir
left a comment
Contributor
There was a problem hiding this comment.
@alan-agius4 thanks for the cleanup 👍
AndrewKushnir
approved these changes
Mar 15, 2024
AndrewKushnir
left a comment
AndrewKushnir
left a comment
Contributor
There was a problem hiding this comment.
Reviewed-for: public-api
alan-agius4
added
action: merge
Member
|
This PR was merged into the repository by commit e0b60ad. |
alxhub
pushed a commit
that referenced
this pull request
Mar 18, 2024
BREAKING CHANGE: Legacy handling or Node.js URL parsing has been removed from `ServerPlatformLocation`. The main differences are; - `pathname` is always suffixed with a `/`. - `port` is empty when `http:` protocol and port in url is `80` - `port` is empty when `https:` protocol and port in url is `443` PR Close #54874
alxhub
pushed a commit
that referenced
this pull request
Mar 18, 2024
This is following a number of cleanups. PR Close #54874
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor(server): remove legacy URL handling logic
BREAKING CHANGE:
Legacy handling or Node.js URL parsing has been removed from
ServerPlatformLocation.The main differences are;
pathnameis always suffixed with a/.portis empty whenhttp:protocol and port in url is80portis empty whenhttps:protocol and port in url is443refactor(server): remove deprecated
useAbsoluteUrlandbaseUrlfromPlatformConfigBREAKING CHANGE: deprecated
useAbsoluteUrlandbaseUrlbeen removed fromPlatformConfig. Provide and absoluteurlinstead.refactor(server): remove deprecated
platformDynamicServerAPIBREAKING CHANGE: deprecated
platformDynamicServerhas been removed. Add animport @angular/compilerand replace the usage withplatformServerrefactor(server): remove deprecated
ServerTransferStateModuleAPIBREAKING CHANGE: deprecated
ServerTransferStateModulehas been removed.TransferStatecan be use without providing this module.