fix(core): ComponentFixture autoDetect feature works like production - #55228
Closed
atscott wants to merge 1 commit into
Closed
fix(core): ComponentFixture autoDetect feature works like production#55228atscott wants to merge 1 commit into
atscott wants to merge 1 commit into
Conversation
angular-robot
Bot
added
the
detected: breaking change
atscott
force-pushed
the
componentfixtureautodetect_saneVersion
branch
4 times, most recently
from
April 6, 2024 15:05
61c7250 to
7ce2963
Compare
pkozlowski-opensource
added
the
area: core
atscott
marked this pull request as draft
April 12, 2024 20:05
atscott
force-pushed
the
componentfixtureautodetect_saneVersion
branch
2 times, most recently
from
July 29, 2024 23:04
c760b3a to
c6d5a61
Compare
atscott
force-pushed
the
componentfixtureautodetect_saneVersion
branch
from
August 8, 2024 19:51
c6d5a61 to
1cafc90
Compare
atscott
added
the
action: global presubmit
atscott
force-pushed
the
componentfixtureautodetect_saneVersion
branch
from
August 8, 2024 19:53
1cafc90 to
eb08ef7
Compare
atscott
force-pushed
the
componentfixtureautodetect_saneVersion
branch
3 times, most recently
from
August 12, 2024 19:26
a5f5cfc to
7419fa1
Compare
atscott
marked this pull request as ready for review
August 13, 2024 21:39
alxhub
approved these changes
Aug 13, 2024
This commit fully integrates the `autoDetect` feature into `ApplicationRef.tick` without special handling for errors. This commit also shares the method of autoDetect for change detection between the zoneless and zone component fixture implementations. The difference is now limited to: * autoDetect is defaulted to true with zoneless * detectChanges with zoneless is AppRef.tick while it is ChangeDetectorRef.detectChanges with zones. This should likely converge more in the future. Not going through AppRef.tick means that the zone fixture does not get guaranteed `afterRender` executions and does not get the rerunning behavior if the fixture is marked dirty by a render hook. BREAKING CHANGE: The `autoDetect` feature of `ComponentFixture` will now attach the fixture to the `ApplicationRef`. As a result, errors during automatic change detection of the fixture be reported to the `ErrorHandler`. This change may cause custom error handlers to observe new failures that were previously unreported.
atscott
force-pushed
the
componentfixtureautodetect_saneVersion
branch
from
August 15, 2024 18:43
7419fa1 to
f4195f4
Compare
atscott
added
action: merge
Contributor
|
This PR was merged into the repository by commit f03d274. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fully integrates the
autoDetectfeature intoApplicationRef.tickwithout special handling for errors.BREAKING CHANGE: The
autoDetectfeature ofComponentFixturewill now report errors to theErrorHandler. Previously, these errors were thrown in asetTimeout. The default behavior ofErrorHandleris to simply log the error to console. This change may cause custom error handlers to observe new failures that were previously unreported.