feat(common): accept undefined inputs in NgTemplateOutlet - #61404
Conversation
Extend types of inputs to include `undefined` to avoid `?? null` when using singals (e.g. `viewChild`). Fixes angular#51225
mmalerba
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: fw-general
Reviewed-for: public-api
|
@devversion You're making a good point. If we consider it a breaking change we won't be able to land it in v20. Maybe let the TGP decide if we consider that breaking ? |
|
TGP is "Green" without having to cleanup g3. I think we can consider this change non breaking. |
|
This PR was merged into the repository by commit 82327f2. The changes were merged into the following branches: main, 20.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Extend types of inputs to include
undefinedto avoid?? nullwhen using singals (e.g.viewChild).Fixes #51225
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Inputs don't accept
undefinedIssue Number: #51225
What is the new behavior?
Accept
undefinedDoes this PR introduce a breaking change?
Other information