fix(angular/material-luxon-adapter): preserve timezone on .clone()#33564
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
crisbeto
approved these changes
Jul 22, 2026
crisbeto
reviewed
Jul 22, 2026
crisbeto
left a comment
crisbeto
left a comment
Member
There was a problem hiding this comment.
Code looks good, but there's a lint failure.
| }); | ||
|
|
||
| it('should respect timezone on clone', () => { | ||
| let dateLocal = DateTime.local(2017, JAN, 1); |
Contributor
Author
There was a problem hiding this comment.
Fixed this and the lint issue too. Thanks for the fast review.
Fixes a bug in the Angular Material LuxonDateAdapter where the .clone() method didn't clone the zone of the original DateTime object and caused issues with the TimePicker component. Fixes angular#33563
laliconfigcat
force-pushed
the
fix-luxon-timezone-issue
branch
from
July 22, 2026 08:32
f57eace to
d6e9db0
Compare
crisbeto
added
action: merge
Member
crisbeto
pushed a commit
that referenced
this pull request
Jul 22, 2026
Fixes a bug in the Angular Material LuxonDateAdapter where the .clone() method didn't clone the zone of the original DateTime object and caused issues with the TimePicker component. (cherry picked from commit 452d3cc)
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(angular/material-luxon-adapter): preserve timezone on .clone()
Fixes a bug in the Angular Material LuxonDateAdapter where the .clone() method didn't clone the zone of the original DateTime object and caused issues with the TimePicker component.
Fixes #33563