Remove direct scheduler BaseOperator refs - #52234
Merged
Merged
Conversation
boring-cyborg
Bot
added
area:API
uranusjr
force-pushed
the
remove-baseoperator-from-core
branch
14 times, most recently
from
June 30, 2025 05:58
3862cd8 to
d297979
Compare
uranusjr
added
the
log exception
uranusjr
force-pushed
the
remove-baseoperator-from-core
branch
7 times, most recently
from
July 2, 2025 06:14
2c48445 to
d51aeab
Compare
uranusjr
force-pushed
the
remove-baseoperator-from-core
branch
2 times, most recently
from
July 2, 2025 07:06
33883e1 to
77fee4c
Compare
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Jul 4, 2025
These methods don't need to exists and makes apache#52234 simpler. These methods aren't used anywhere in the code anymore, there usages was mainly in Core tests since providers were fixed as part of apache#52378.
uranusjr
force-pushed
the
remove-baseoperator-from-core
branch
from
July 6, 2025 19:41
acb6bea to
54ec069
Compare
kaxil
reviewed
Jul 6, 2025
uranusjr
force-pushed
the
remove-baseoperator-from-core
branch
from
July 6, 2025 21:44
54ec069 to
9e1c268
Compare
kaxil
reviewed
Jul 7, 2025
kaxil
added
the
full tests needed
kaxil
reviewed
Jul 7, 2025
kaxil
reviewed
Jul 7, 2025
kaxil
reviewed
Jul 7, 2025
kaxil
reviewed
Jul 7, 2025
kaxil
left a comment
kaxil
left a comment
Member
There was a problem hiding this comment.
Looks good on high-level but want to look at the s10n changes more closely.
cc @ashb @amoghrajesh - More eyes will help here.
kaxil
force-pushed
the
remove-baseoperator-from-core
branch
from
July 7, 2025 20:35
9e1c268 to
14598c4
Compare
Member
|
(rebased on main to get latest changes & running with full-tests now) |
ashb
reviewed
Jul 8, 2025
Member
|
I want to take a look at what the serialized Dag JSON looks like with this change too. |
uranusjr
force-pushed
the
remove-baseoperator-from-core
branch
3 times, most recently
from
July 10, 2025 05:25
6423b6b to
7f9c6f7
Compare
Member
Author
|
Serialised dag JSON does not change; this only removes the JSON → SerializedBaseOperator part; the SDK operator → JSON part is not affected. |
uranusjr
force-pushed
the
remove-baseoperator-from-core
branch
from
July 10, 2025 06:16
7f9c6f7 to
94cc204
Compare
uranusjr
force-pushed
the
remove-baseoperator-from-core
branch
from
July 10, 2025 07:12
94cc204 to
5e3b5e4
Compare
uranusjr
commented
Jul 10, 2025
kaxil
approved these changes
Jul 10, 2025
They are either changed to SerializedBaseOperator or the SDK BaseOperator. If this works, we can work on combining the scheduler BaseOperator into SerializedBaseOperator, and remove SDK BaseOperator base references in the scheduler. Scheduler BaseOperator is now removed entirely since SerializedBaseOperator is all that's needed in the scheduler. Furthermore, SerializedBaseOperator no longer inherits from the SDK BaseOperator, so in the future we can separate the two inheritance tree entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They are either changed to SerializedBaseOperator or the SDK BaseOperator. If this works, we can work on combining the scheduler BaseOperator into SerializedBaseOperator, and remove SDK BaseOperator base references in the scheduler.