Use allowlisted Rust toolchain action revision

.github/workflows/build.yml

@@ -48,7 +48,7 @@ jobs:
       - uses: actions/checkout@v6
 
       - name: Setup Rust
-        uses: dtolnay/rust-toolchain@4be7066ada62dd38de10e7b70166bc74ed198c30
+        uses: dtolnay/rust-toolchain@4cda84d5c5c54efe2404f9d843567869ab1699d4
         with:
           toolchain: "nightly"
           components: rustfmt
@@ -152,7 +152,7 @@ jobs:
           path: .
 
       - name: Setup Rust
-        uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8
+        uses: dtolnay/rust-toolchain@4cda84d5c5c54efe2404f9d843567869ab1699d4
 
       - name: Cache Cargo
         uses: Swatinem/rust-cache@v2
@@ -231,7 +231,7 @@ jobs:
           path: .
 
       - name: Setup Rust
-        uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8
+        uses: dtolnay/rust-toolchain@4cda84d5c5c54efe2404f9d843567869ab1699d4
 
       - name: Cache Cargo
         uses: Swatinem/rust-cache@v2
@@ -286,7 +286,8 @@ jobs:
     steps:
       - uses: actions/checkout@v6
 
-      - uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8
+      - name: Setup Rust
+        uses: dtolnay/rust-toolchain@4cda84d5c5c54efe2404f9d843567869ab1699d4
 
       - run: rm LICENSE.txt
       - name: Download LICENSE.txt
@@ -368,7 +369,8 @@ jobs:
     steps:
       - uses: actions/checkout@v6
 
-      - uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8
+      - name: Setup Rust
+        uses: dtolnay/rust-toolchain@4cda84d5c5c54efe2404f9d843567869ab1699d4
 
       - run: rm LICENSE.txt
       - name: Download LICENSE.txt

crates/core/src/expr.rs

@@ -433,7 +433,7 @@ impl PyExpr {
             Expr::Literal(scalar_value, _) => scalar_to_pyarrow(scalar_value, py),
             _ => Err(py_type_err(format!(
                 "Non Expr::Literal encountered in types: {:?}",
-                &self.expr
+                self.expr
             ))),
         }
     }
@@ -612,7 +612,7 @@ impl PyExpr {
             _ => {
                 return Err(py_type_err(format!(
                     "Catch all triggered in get_operator_name: {:?}",
-                    &self.expr
+                    self.expr
                 )));
             }
         })

crates/core/src/expr/aggregate.rs

@@ -65,8 +65,8 @@ impl Display for PyAggregate {
             \nAggregates(s): {:?}
             \nInput: {:?}
             \nProjected Schema: {:?}",
-            &self.aggregate.group_expr,
-            &self.aggregate.aggr_expr,
+            self.aggregate.group_expr,
+            self.aggregate.aggr_expr,
             self.aggregate.input,
             self.aggregate.schema
         )

crates/core/src/expr/alias.rs

@@ -53,7 +53,7 @@ impl Display for PyAlias {
             "Alias
             \nExpr: `{:?}`
             \nAlias Name: `{}`",
-            &self.alias.expr, &self.alias.name
+            self.alias.expr, self.alias.name
         )
     }
 }

crates/core/src/expr/between.rs

@@ -55,7 +55,7 @@ impl Display for PyBetween {
             Negated: {:?}
             Low: {:?}
             High: {:?}",
-            &self.between.expr, &self.between.negated, &self.between.low, &self.between.high
+            self.between.expr, self.between.negated, self.between.low, self.between.high
         )
     }
 }

crates/core/src/expr/bool_expr.rs

@@ -46,7 +46,7 @@ impl Display for PyNot {
             f,
             "Not
             Expr: {}",
-            &self.expr
+            self.expr
         )
     }
 }
@@ -82,7 +82,7 @@ impl Display for PyIsNotNull {
             f,
             "IsNotNull
             Expr: {}",
-            &self.expr
+            self.expr
         )
     }
 }
@@ -118,7 +118,7 @@ impl Display for PyIsNull {
             f,
             "IsNull
             Expr: {}",
-            &self.expr
+            self.expr
         )
     }
 }
@@ -154,7 +154,7 @@ impl Display for PyIsTrue {
             f,
             "IsTrue
             Expr: {}",
-            &self.expr
+            self.expr
         )
     }
 }
@@ -190,7 +190,7 @@ impl Display for PyIsFalse {
             f,
             "IsFalse
             Expr: {}",
-            &self.expr
+            self.expr
         )
     }
 }
@@ -226,7 +226,7 @@ impl Display for PyIsUnknown {
             f,
             "IsUnknown
             Expr: {}",
-            &self.expr
+            self.expr
         )
     }
 }
@@ -262,7 +262,7 @@ impl Display for PyIsNotTrue {
             f,
             "IsNotTrue
             Expr: {}",
-            &self.expr
+            self.expr
         )
     }
 }
@@ -298,7 +298,7 @@ impl Display for PyIsNotFalse {
             f,
             "IsNotFalse
             Expr: {}",
-            &self.expr
+            self.expr
         )
     }
 }
@@ -334,7 +334,7 @@ impl Display for PyIsNotUnknown {
             f,
             "IsNotUnknown
             Expr: {}",
-            &self.expr
+            self.expr
         )
     }
 }
@@ -370,7 +370,7 @@ impl Display for PyNegative {
             f,
             "Negative
             Expr: {}",
-            &self.expr
+            self.expr
         )
     }
 }

crates/core/src/expr/create_memory_table.rs

@@ -57,10 +57,7 @@ impl Display for PyCreateMemoryTable {
             Input: {:?}
             if_not_exists: {:?}
             or_replace: {:?}",
-            &self.create.name,
-            &self.create.input,
-            &self.create.if_not_exists,
-            &self.create.or_replace,
+            self.create.name, self.create.input, self.create.if_not_exists, self.create.or_replace,
         )
     }
 }

crates/core/src/expr/create_view.rs

@@ -58,7 +58,7 @@ impl Display for PyCreateView {
             input: {:?}
             or_replace: {:?}
             definition: {:?}",
-            &self.create.name, &self.create.input, &self.create.or_replace, &self.create.definition,
+            self.create.name, self.create.input, self.create.or_replace, self.create.definition,
         )
     }
 }

crates/core/src/expr/drop_table.rs

@@ -56,7 +56,7 @@ impl Display for PyDropTable {
             name: {:?}
             if_exists: {:?}
             schema: {:?}",
-            &self.drop.name, &self.drop.if_exists, &self.drop.schema,
+            self.drop.name, self.drop.if_exists, self.drop.schema,
         )
     }
 }

crates/core/src/expr/empty_relation.rs

@@ -56,7 +56,7 @@ impl Display for PyEmptyRelation {
             "Empty Relation
             Produce One Row: {:?}
             Schema: {:?}",
-            &self.empty.produce_one_row, &self.empty.schema
+            self.empty.produce_one_row, self.empty.schema
         )
     }
 }

crates/core/src/expr/explain.rs

@@ -61,11 +61,11 @@ impl Display for PyExplain {
             stringified_plans: {:?}
             schema: {:?}
             logical_optimization_succeeded: {:?}",
-            &self.explain.verbose,
-            &self.explain.plan,
-            &self.explain.stringified_plans,
-            &self.explain.schema,
-            &self.explain.logical_optimization_succeeded
+            self.explain.verbose,
+            self.explain.plan,
+            self.explain.stringified_plans,
+            self.explain.schema,
+            self.explain.logical_optimization_succeeded
         )
     }
 }

crates/core/src/expr/filter.rs

@@ -57,7 +57,7 @@ impl Display for PyFilter {
             "Filter
             Predicate: {:?}
             Input: {:?}",
-            &self.filter.predicate, &self.filter.input
+            self.filter.predicate, self.filter.input
         )
     }
 }

crates/core/src/expr/higher_order_function.rs

@@ -52,7 +52,7 @@ impl Display for PyHigherOrderFunction {
             f,
             "HigherOrderFunction(name={}, args={:?})",
             self.higher_order.name(),
-            &self.higher_order.args,
+            self.higher_order.args,
         )
     }
 }

crates/core/src/expr/join.rs

@@ -132,14 +132,14 @@ impl Display for PyJoin {
             JoinConstraint: {:?}
             Schema: {:?}
             NullEquality: {:?}",
-            &self.join.left,
-            &self.join.right,
-            &self.join.on,
-            &self.join.filter,
-            &self.join.join_type,
-            &self.join.join_constraint,
-            &self.join.schema,
-            &self.join.null_equality,
+            self.join.left,
+            self.join.right,
+            self.join.on,
+            self.join.filter,
+            self.join.join_type,
+            self.join.join_constraint,
+            self.join.schema,
+            self.join.null_equality,
         )
     }
 }

crates/core/src/expr/lambda.rs

@@ -51,7 +51,7 @@ impl Display for PyLambda {
         write!(
             f,
             "Lambda(params={:?}, body={:?})",
-            &self.lambda.params, &self.lambda.body,
+            self.lambda.params, self.lambda.body,
         )
     }
 }

crates/core/src/expr/lambda_variable.rs

@@ -46,7 +46,7 @@ impl From<PyLambdaVariable> for LambdaVariable {
 
 impl Display for PyLambdaVariable {
     fn fmt(&self, f: &mut Formatter) -> fmt::Result {
-        write!(f, "LambdaVariable({})", &self.variable.name)
+        write!(f, "LambdaVariable({})", self.variable.name)
     }
 }
 

crates/core/src/expr/like.rs

@@ -55,10 +55,10 @@ impl Display for PyLike {
             Expr: {:?}
             Pattern: {:?}
             Escape_Char: {:?}",
-            &self.negated(),
-            &self.expr(),
-            &self.pattern(),
-            &self.escape_char()
+            self.negated(),
+            self.expr(),
+            self.pattern(),
+            self.escape_char()
         )
     }
 }
@@ -119,10 +119,10 @@ impl Display for PyILike {
             Expr: {:?}
             Pattern: {:?}
             Escape_Char: {:?}",
-            &self.negated(),
-            &self.expr(),
-            &self.pattern(),
-            &self.escape_char()
+            self.negated(),
+            self.expr(),
+            self.pattern(),
+            self.escape_char()
         )
     }
 }
@@ -183,10 +183,10 @@ impl Display for PySimilarTo {
             Expr: {:?}
             Pattern: {:?}
             Escape_Char: {:?}",
-            &self.negated(),
-            &self.expr(),
-            &self.pattern(),
-            &self.escape_char()
+            self.negated(),
+            self.expr(),
+            self.pattern(),
+            self.escape_char()
         )
     }
 }

crates/core/src/expr/limit.rs

@@ -57,7 +57,7 @@ impl Display for PyLimit {
             Skip: {:?}
             Fetch: {:?}
             Input: {:?}",
-            &self.limit.skip, &self.limit.fetch, &self.limit.input
+            self.limit.skip, self.limit.fetch, self.limit.input
         )
     }
 }

crates/core/src/expr/projection.rs

@@ -65,7 +65,7 @@ impl Display for PyProjection {
             \nExpr(s): {:?}
             \nInput: {:?}
             \nProjected Schema: {:?}",
-            &self.projection.expr, &self.projection.input, &self.projection.schema,
+            self.projection.expr, self.projection.input, self.projection.schema,
         )
     }
 }

crates/core/src/expr/repartition.rs

@@ -82,7 +82,7 @@ impl Display for PyRepartition {
             "Repartition
             input: {:?}
             partitioning_scheme: {:?}",
-            &self.repartition.input, &self.repartition.partitioning_scheme,
+            self.repartition.input, self.repartition.partitioning_scheme,
         )
     }
 }

crates/core/src/expr/sort.rs

@@ -61,7 +61,7 @@ impl Display for PySort {
             \nExpr(s): {:?}
             \nInput: {:?}
             \nSchema: {:?}",
-            &self.sort.expr,
+            self.sort.expr,
             self.sort.input,
             self.sort.input.schema()
         )

crates/core/src/expr/sort_expr.rs

@@ -54,7 +54,7 @@ impl Display for PySortExpr {
             Expr: {:?}
             Asc: {:?}
             NullsFirst: {:?}",
-            &self.sort.expr, &self.sort.asc, &self.sort.nulls_first
+            self.sort.expr, self.sort.asc, self.sort.nulls_first
         )
     }
 }