[MNG-7432] Proposed UT for maven-3.9.x and 3.8.x - #706
Closed
cstamas wants to merge 1 commit into
Closed
Conversation
This UT makes sure that DefaultMaven sets up proper type of WorkspaceReader in RepositorySystemSession. For example, this UT fails with current maven-3.8.x and maven-3.9.x branches.
8 tasks
Contributor
|
@michael-o whats the process here, should the test be included (with |
Member
|
Just take over the UT to your branch and then this PR can be closed. That makes it easier to commit to 3.9/3.8.x. |
Member
Author
|
Yes please, just lift it. Am currently a bit overwhelmed with $other work, otherwise would help with all of this. No need to retain author or anything (is few liner), just lift it/squash all right. |
Contributor
|
All right I'll try that! Thanks for the Test it looks quite straight forward but I'm not sure I would have been able to come up with such one :-) |
|
Resolve #9148 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This UT makes sure that DefaultMaven sets up proper type
of WorkspaceReader in RepositorySystemSession.
For example, this UT fails with current maven-3.8.x and
maven-3.9.x branches due MNG-7432