Tls injection mechanism - #1517
Open
sergejskozlovics wants to merge 926 commits into
Open
Conversation
Collaborator
|
Hi Sergejs, thanks for the PR. It will be a while before a full review can be done, but on a first pass I have seen some basic issues:
We are certainly interested in getting PQC algorithms into TLS, but our intention would be to proceed by publishing algorithms in the BC provider as usual, then having TLS add the registrar entries from the relevant standards and support them when it can find the algorithm via the provider. Perhaps you could comment a little about what you have in mind in terms of the basic "injection" idea here, particularly in comparison to the existing provider-based mechanism. |
2. add TlsCryptoParameters
…edDataList, PGPCompressedDataGenerator and PGPUtil. Extract PGPDefaultSignatureGenerator.getAttriubtesHash from PGPSignature and PGPSignatureGenerator.Invert PGPSignatureGenerator.packetPresent to packetNotPresent.
…er allow Camellia. Add tests to BcImplProvider, BcKeyFingerprintCalculator, BcPGPContentVerifierBuilderProvider, BcPGPDataEncryptorBuilder and JcePGPDataEncryptorBuilder.
…Marker, PGPOnePassSignature, PGPPadding, PGPSignature and PGPLiteralDataGenerator.
…Converter. Add tests for JcaPGPDigestCalculatorProviderBuilder, BcPGPKeyConverter, JcaPGPKeyConverter, and JcaPGPDigestCalculatorProviderBuilder.
…ilder, and PGPKeyRingGenerator
…Data, PGPSignature, JcaPGPContentSignerBuilder, JcaPGPKeyPair, PGPSignatureList and PGPEncryptedDataGenerator.
…GPLiteralData, and PGPUserAttributeSubpacketVectorGenerator.
…cPGPKeyConverter.
…Factory, BcPublicKeyKeyEncryptionMethodGenerator, JcaPGPContentVerifierBuilderProvider, etc.
Signed-off-by: Alexander Scheel <alexander.scheel@keyfactor.com>
As reported by @CipherGato, CCM fails to decrypt a full-length message for n=13, q=2 (maximum length 65,535). This is because the input message already includes the flags and nonce components (B0 from SP800 38C). Correctly handle full-length CCM decryption. Resolves: bcgit#1570 Signed-off-by: Alexander Scheel <alexander.scheel@keyfactor.com>
Removed Camellia wrap enable property from OpenPGP (not required).
Signed-off-by: Alexander Scheel <alexander.scheel@keyfactor.com>
…ving only Asn1Bridge and Asn1BridgeForInjectedSigAlgs there; no dependency on the tls package
…jection Mechanism. Besides, UniversalKeyPairGenerator is difficult to implement.
…fallback algorithm for the BC adapter (since <hash-name>WITHRSAANDMGF1 sometimes is not found)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have developed a TLS injection mechanism. It can be used to inject PQC algorithms (KEMs and signature algorithms) into TLS 1.3. The injection mechanism is located in the org.bouncycastle.tls.injection package, where the InjectionPoint class has been defined. Then, there are many places where InjectionPoint is consulted for injected KEMs and signature algorithms, which are added to the corresponding lists of supported TLS algorithms.