Created issue templates and pull request template - #1748
Open
KarolinHem wants to merge 2306 commits into
Open
Conversation
Prior to this chance, calling e.g. setKeyFlags() on a subpacket generator that already contained key flags would introduce a duplicate key flag subpacket. I fixed this behavior by changing all setXYZ() methods to first remove any packet occurrences of the same type. NOTE: This breaks the current behavior of setRevocable() and setExportable(), as these method previously did a check to see if another packet of the same type was present and threw an IllegalStateException. Now, no such exception is thrown and instead the later method invocation takes precedence. NOTE: If you rely on duplicate packets (e.g. in your tests), you can still introduce duplicates by adding the duplicate packet via addCustomSubpacket(YourPacket).
added support for rfc9579 (PBMAC1 with PBKDF2) to PKCS12KeyStoreSpi See merge request root/bc-java!67
… into 2013-openpgp-pgpsignaturesubpacketgenerator
Fix the bug of ParallelHash that block size is set to 0. See merge request root/bc-java!76
PGPSignatureSubpacketGenerator: setXYZ() now removes duplicates. See merge request root/bc-java!77
SecretKeyPacket: Properly pass newPacketFormat down to PublicKeyPacket See merge request root/bc-java!74
Update of KeyIdentifier class and test See merge request root/bc-java!91
Refactor of Falcon code See merge request root/bc-java!90
Update OQS OIDs (falcon etc). See merge request root/bc-java!89
# Conflicts: # core/src/main/java/org/bouncycastle/asn1/bc/BCObjectIdentifiers.java
Snova See merge request root/bc-java!83
Update AEADProtectedPGPSecretKeyTest See merge request root/bc-java!92
Io overlap dbbc child See merge request root/bc-java!87
OpenPGP API Phase 1 See merge request root/bc-java!93
removed use of junit from SimpleTest
RFC 8103 ChaCha20-Poly1305 See merge request root/bc-java!95
Fixed broken link to Contributing Guidelines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added to guide users to create new issues and pull requests, according to Keyfactor Community templates.