🚀 Release PR - #263
Merged
Merged
Conversation
Releases: react-router-devtools@6.2.2 [skip ci]
|
@AlemTuzlak Did the CI fail to publish this v6.2.2 to npm? It isn't available. |
AlemTuzlak
added a commit
that referenced
this pull request
Jul 28, 2026
…sion commit
`.changeset/config.json` had `"commit": true`, which changesets normalizes to
`["@changesets/cli/commit", { skipCI: "version" }]`. That makes `changeset
version` create the version commit itself, appending GitHub's skip-ci directive
to the message:
RELEASING: Releasing 1 package(s)
Releases:
react-router-devtools@6.2.2
<skip-ci directive>
Two consequences:
1. The `commit: "chore: release"` message configured in the Release workflow was
never used, because the action had nothing left to commit.
2. The directive survived the merge of the Release PR onto main, so GitHub
skipped every workflow on that push. The Release workflow -- the only thing
that runs `changeset publish` -- never fired.
Net effect: merging a Release PR bumped the version, wrote the CHANGELOG and
consumed the changeset, but published nothing. This bit 6.2.2 (bumped in #263 on
Jun 19, never reached npm; zero workflow runs recorded against that commit). It
was latent before that only because an unrelated push to main happened soon
after each release and picked up the publish by accident -- that is how 6.2.1
shipped.
Setting `"commit": false` leaves the commit to changesets/action, which uses the
workflow's `chore: release` message with no skip directive, so merging a Release
PR triggers Release and publishes.
Note: this message deliberately avoids spelling the directive literally, since
GitHub matches it anywhere in a commit message -- an earlier draft of this very
commit skipped its own CI.
AlemTuzlak
added a commit
that referenced
this pull request
Jul 28, 2026
…ing red) (#267) * fix(ci): stop changesets from stamping a skip-ci directive on the version commit `.changeset/config.json` had `"commit": true`, which changesets normalizes to `["@changesets/cli/commit", { skipCI: "version" }]`. That makes `changeset version` create the version commit itself, appending GitHub's skip-ci directive to the message: RELEASING: Releasing 1 package(s) Releases: react-router-devtools@6.2.2 <skip-ci directive> Two consequences: 1. The `commit: "chore: release"` message configured in the Release workflow was never used, because the action had nothing left to commit. 2. The directive survived the merge of the Release PR onto main, so GitHub skipped every workflow on that push. The Release workflow -- the only thing that runs `changeset publish` -- never fired. Net effect: merging a Release PR bumped the version, wrote the CHANGELOG and consumed the changeset, but published nothing. This bit 6.2.2 (bumped in #263 on Jun 19, never reached npm; zero workflow runs recorded against that commit). It was latent before that only because an unrelated push to main happened soon after each release and picked up the publish by accident -- that is how 6.2.1 shipped. Setting `"commit": false` leaves the commit to changesets/action, which uses the workflow's `chore: release` message with no skip directive, so merging a Release PR triggers Release and publishes. Note: this message deliberately avoids spelling the directive literally, since GitHub matches it anywhere in a commit message -- an earlier draft of this very commit skipped its own CI. * fix(ci): keep main formatted after a release version bump `changeset version` rewrites `packages/react-router-devtools/package.json` with its own JSON printer, which expands `"files": ["dist"]` onto three lines. Biome wants it collapsed, so every release commit lands a formatting violation on main, and Biome lint then fails on that commit and on every PR opened afterwards until somebody notices and collapses it by hand. It has been ping-ponging for three releases straight: a46c47f RELEASING: ... expands (release breaks it) 0263127 ci: harden release collapses (hand fix) becd7c9 RELEASING: ... expands (release breaks it again) main is currently in the expanded state, which is why the Validation Pipeline went red on the Vite 8 PR and on the first push of this branch. Chaining `biome format --write .` after `changeset version` closes the loop, so the version commit is formatted when it is created rather than after the fact. Same chain added to `local-release` so manual releases behave identically. Verified end to end with a scratch changeset: `changeset version` expands the array, the formatter collapses it back ("Fixed 1 file"), and `biome check .` passes across all 224 files. Also confirms the companion `"commit": false` change works -- changesets now reports "Review them and commit at your leisure" instead of creating its own commit. The collapse of `files` in this commit repairs main's current state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
react-router-devtools@6.2.2
Patch Changes
aae92e4: Fix
Cannot find package 'vite-node'(bug: Cannot find package 'vite-node' after upgrading to React Router v8 #261) and support React Router 8 / Vite 8.vite-nodeis imported at runtime by the Vite plugin but was only declared as adevDependency, so consumers relied on it being a phantom dependency of@react-router/dev@7. React Router 8 droppedvite-nodefrom its dependencies, which broke resolution for any project on RR8.vite-nodeis now a realdependency(^5.0.0 || ^6.0.0, covering both Vite 7 and Vite 8), and thevitepeer range was tidied to>=5.0.0so it explicitly admits Vite 8 alongside React Router's existing>=7.0.0peer range (which already admits v8).