[pull] develop from baserow:develop#377
Merged
Merged
Conversation
…ules (#1722) (#5755) * docs: add ADR for button field workflow actions (#1722) * docs: renumber button field ADR to 006 to avoid collision with 005 * docs: rework button field ADR to cover integrations, ownership, and import/export from review * docs: split run-as user from row history attribution in button field ADR Rewrites section 5 so permission checks keep running as the integration's authorized_user while row history records the clicking user as initiator from v1. Also removes speculation about the future Agent feature, and documents id_mapping remapping in the import section. * docs: close review gaps in button field ADR Names the initiator mechanism and the configuration permission boundary in section 5, serializes dispatch per button cell, defines row context snapshot semantics, excludes database tokens from clicking, and covers target table deletion under common operations. * docs: rework button field ADR to run actions as the clicking user Adopts the actor approach from review: permission checks, row history, and created-by all see the clicking user, with no on-behalf-of execution. The Local Baserow integration becomes an internal auto-created object, removing the v1 settings UI, credential stripping concerns, and the initiator extension. * docs: simplify button field ADR import pass per review Defers every service and formula reference on import instead of checking resolvability first, and documents why the second pass needs no dependency ordering between buttons. * docs: apply review wording fixes to button field ADR Marks the automation base-class PR as parallel rather than a dependency, softens the Option 1 con to a maintenance note, states both data providers exist on backend and frontend, and reuses the builder's action error state for reconfigure. * docs: drop the integration requirement for v1 button actions Adopts the optional-integration direction from review: database services authorize and execute as the actor with no integration attached, v1 ships no integration object or settings UI, and the nullable-FK-versus-dedicated-object choice is left to implementation. * docs: mark button field ADR accepted with final review touches Flips the status to Accepted after core-team approval, routes the failure toast through the API participant in the sequence diagram, and notes the upstream dependencies are scoped core/services changes, not a refactor. * docs: scope the no-integration decision to Local Baserow services Clarifies section 5 after review: only the Local Baserow integration is unnecessary for buttons, since it just carries a user and buttons use the clicker. External integrations like SMTP and Slack carry real configuration and stay required when external action types arrive. * docs: tighten button field ADR claims and record integration ownership plan Names the undo mechanism (perform without registering, keep the action_done signal), corrects the scope of the actor fallback work, fixes the builder-unchanged justification, defers actor auditing in the integration-present branch, fails clicks on field-level permission gaps instead of skipping fields, and records the agreed integration ownership sequence: explicit sharing warnings when external types arrive, created_by plus is_shared private-by-default later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )