Flaky test: TestPrunePromptTermination

[vvoland]

Description

 --- FAIL: TestPrunePromptTermination (0.01s)
    prune_test.go:128: assertion failed: error is "image prune has been cancelled" (errdefs.errCancelled), not "prompt terminated" (command.ErrPromptTerminated errdefs.errCancelled)
FAIL
coverage: 52.0% of statements
FAIL	github.com/docker/cli/cli/comma

Reproduce

https://github.com/docker/cli/actions/runs/13185262897/job/36805753289?pr=5754

Expected behavior

No response

docker version

-

docker info

-

Additional Info

No response

[captainmo1]

🐛 TestPrunePromptTermination Fails Intermittently Due to Timing Issue

The test occasionally fails because command.PromptForConfirmation() is reached before the prompt is cancelled, leading to inconsistent behavior.

1. TestPrunePromptTermination calls:
2. TerminatePrompt, which calls:
3. runPrune, which calls:
4. command.PromptForConfirmation()
   • The GitHub Actions runner automatically passes "no" if the prompt is not cancelled in time.
5. As a result, it returns "image prune has been cancelled" instead of the expected "prompt terminated".

I don't see a way around this without adding code to the runPrune function(not recommended)