Skip to content

Disable newly added tests on interpreter - #131250

Merged
BrzVlad merged 1 commit into
dotnet:mainfrom
BrzVlad:disable-xml-attribute-perf
Jul 24, 2026
Merged

Disable newly added tests on interpreter#131250
BrzVlad merged 1 commit into
dotnet:mainfrom
BrzVlad:disable-xml-attribute-perf

Conversation

@BrzVlad

@BrzVlad BrzVlad commented Jul 23, 2026

Copy link
Copy Markdown
Member

Some of the tests timeout when running under coreclr interpreter, which is much slower than jit.

Tests added in #130968

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @BrzVlad, @janvorli
See info in area-owners.md if you want to be subscribed.

@BrzVlad

BrzVlad commented Jul 23, 2026

Copy link
Copy Markdown
Member Author

@eiriktsarpalis @krwq I'm wondering if these tests would better be suited as a microbenchmark in dotnet/performance rather than in the library test suite. We would also have better tracking if performance degrades on them.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts System.Private.Xml performance-oriented attribute-duplicate-check tests to be skipped when running under the CoreCLR interpreter, avoiding interpreter-run timeouts while keeping coverage for normal JIT runs.

Changes:

  • Converted the affected [Fact] tests to [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotCoreClrInterpreter))].
  • Applied the same condition to the Release-only (#if !DEBUG) variant of the test.

@eiriktsarpalis

Copy link
Copy Markdown
Member

@eiriktsarpalis @krwq I'm wondering if these tests would better be suited as a microbenchmark in dotnet/performance rather than in the library test suite. We would also have better tracking if performance degrades on them.

Agreed.

@BrzVlad

BrzVlad commented Jul 24, 2026

Copy link
Copy Markdown
Member Author

can we merge this in the meantime to fix CI ?

@BrzVlad
BrzVlad merged commit 7827553 into dotnet:main Jul 24, 2026
80 of 85 checks passed
hez2010 pushed a commit to hez2010/runtime that referenced this pull request Jul 26, 2026
Some of the tests timeout when running under coreclr interpreter, which
is much slower than jit.

Tests added in dotnet#130968
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 11.0-rc1 milestone Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants