fix: narrow future() and future_safe() param types from Coroutine to Awaitable (#2404)#2456
Open
fazalpsinfo-cmyk wants to merge 1 commit into
Open
Conversation
…Awaitable (dry-python#2404) future() and future_safe() only await the callable result — they do not use send() or throw(). Changing the parameter type from Coroutine[SendType, ReturnType, YieldType] to Awaitable[YieldType] accepts a broader range of awaitables (asyncio Tasks, wrapped coroutines, etc.) without losing type safety. Removed unused _SecondType TypeVar. Fixes dry-python#2404
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2456 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 80 81 +1
Lines 2485 2564 +79
Branches 437 44 -393
==========================================
+ Hits 2485 2564 +79 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
future()andfuture_safe()currently require their decorated function to returnCoroutine[SendType, ReturnType, YieldType], but they onlyawaitthe result — they never usesend()orthrow(). This means valid async functions that return otherAwaitabletypes (e.g.asyncio.Task, wrapped coroutines) are rejected by type checkers.Fix: Changed the parameter type from
Coroutine[_FirstType, _SecondType, _ValueType_co]toAwaitable[_ValueType_co]in allfuture()andfuture_safe()signatures (both overloads and implementation). Removed the now-unused_SecondTypeTypeVar.Closes: #2404
If you find this useful, consider supporting my work: https://buymeacoffee.com/muhamedfazalps